Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5553)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 2540523003: Use standardized accelerator-to-shortcut code for new backspace shortcut UI. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index a2eb2485ce0a048df67e24ac2654ca32e36faab1..814405f0d56d466d7bb5e1ace282dce6604c5f7d 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -164,7 +164,7 @@ class BrowserWindow : public ui::BaseWindow {
// Shows a notice teaching the user the new shortcut for going back or forward
// if the user has pressed the old shortcut more than once in three seconds
// and the bubble has been shown less than five times.
- virtual void MaybeShowNewBackShortcutBubble(bool forward) = 0;
+ virtual void MaybeShowNewBackShortcutBubble(int command_id) = 0;
sky 2016/11/29 00:14:54 I like the boolean here (or use an enum) as it mak
Peter Kasting 2016/11/29 00:58:38 I thought about this some when making the change,
sky 2016/11/29 04:22:57 It's certainly more general and it only works righ
// Hides the new back shortcut bubble, if showing, by fading it out.
virtual void HideNewBackShortcutBubble() = 0;
« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698