Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2540513003: [NaCl SDK] IPV6_JOIN_GROUP should call JoinGroup, not LeaveGroup (Closed)

Created:
4 years ago by Kevin Cernekee
Modified:
4 years ago
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] IPV6_JOIN_GROUP should call JoinGroup, not LeaveGroup Looks like a possible C&P error. Compile-tested only. BUG=none TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk Committed: https://crrev.com/f88241b5684ce017275f87ecb59b2a3db6c0facf Cr-Commit-Position: refs/heads/master@{#434851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M native_client_sdk/src/libraries/nacl_io/socket/udp_node.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Kevin Cernekee
4 years ago (2016-11-28 23:49:13 UTC) #2
Sam Clegg
Good find. Sad we don't have tests for this code :( Can you add the ...
4 years ago (2016-11-28 23:53:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540513003/1
4 years ago (2016-11-29 02:14:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 02:58:03 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-29 03:04:17 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f88241b5684ce017275f87ecb59b2a3db6c0facf
Cr-Commit-Position: refs/heads/master@{#434851}

Powered by Google App Engine
This is Rietveld 408576698