Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2540483004:
[DevTools] Pin the infobar to the top of the page (Closed)
|
Created:
4 years ago by eostroukhov Modified:
4 years ago CC:
chromium-reviews, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Pin the infobar to the top of the page
This fixes following issues:
1. Infobar is still visible when the user scrolls down.
2. Double scroll bar issues are fixed.
3. Gap above the headers is reduced.
BUG=668400, 661456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/203fe850b9f974f324bda2c0a30707f2d4bd77bb
Cr-Commit-Position: refs/heads/master@{#436072}
Patch Set 1 #Patch Set 2 : [DevTools] Pin infobar to the top of the page #Messages
Total messages: 27 (19 generated)
Description was changed from ========== [DevTools] Do not reserve space for infobar BUG=668400 ========== to ========== [DevTools] Do not reserve space for infobar BUG=668400 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
eostroukhov@chromium.org changed reviewers: + paulirish@chromium.org, pfeldman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/29 20:13:08, eostroukhov wrote: We have to reserve it - otherwise it flickers.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from
==========
[DevTools] Do not reserve space for infobar
BUG=668400
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
[DevTools] Pin the infobar to the top of the page
This fixes following issues:
1. Infobar is still visible when the user scrolls down.
2. Double scroll bar issues are fixed.
3. Gap above the headers is reduced.
BUG=668400, 661456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
On 2016/11/29 21:41:56, pfeldman wrote: > On 2016/11/29 20:13:08, eostroukhov wrote: > > We have to reserve it - otherwise it flickers. Fixed flickering by keeping the padding on top while reducing its size.
Thank you for the review. CL updated - please take another look. Note the changed description, the scope of the CL had changed a bit.
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by eostroukhov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480714599762860,
"parent_rev": "9ac428faf8e25b4e924b37b15cdde86ff4ce1cca", "commit_rev":
"032d4a575090b40212d496f71f9c487729aefb97"}
Message was sent while issue was closed.
Description was changed from
==========
[DevTools] Pin the infobar to the top of the page
This fixes following issues:
1. Infobar is still visible when the user scrolls down.
2. Double scroll bar issues are fixed.
3. Gap above the headers is reduced.
BUG=668400, 661456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
[DevTools] Pin the infobar to the top of the page
This fixes following issues:
1. Infobar is still visible when the user scrolls down.
2. Double scroll bar issues are fixed.
3. Gap above the headers is reduced.
BUG=668400, 661456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from
==========
[DevTools] Pin the infobar to the top of the page
This fixes following issues:
1. Infobar is still visible when the user scrolls down.
2. Double scroll bar issues are fixed.
3. Gap above the headers is reduced.
BUG=668400, 661456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
[DevTools] Pin the infobar to the top of the page
This fixes following issues:
1. Infobar is still visible when the user scrolls down.
2. Double scroll bar issues are fixed.
3. Gap above the headers is reduced.
BUG=668400, 661456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/203fe850b9f974f324bda2c0a30707f2d4bd77bb
Cr-Commit-Position: refs/heads/master@{#436072}
==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/203fe850b9f974f324bda2c0a30707f2d4bd77bb Cr-Commit-Position: refs/heads/master@{#436072} |
