chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc - Issue 2540483002: Allow Offline MHTML save operations to succeed even with missing frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

Issue 2540483002: Allow Offline MHTML save operations to succeed even with missing frames.

Patch Set: Address code review comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

index 0600f24a74e876b5134ace330460983e24cd0e5e..85a43175131dc8b8b126acf248d9c47f1fbb6802 100644

--- a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

+++ b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

@@ -134,6 +134,7 @@ void OfflinePageMHTMLArchiver::GenerateMHTML(

content::MHTMLGenerationParams params(file_path);

params.use_binary_encoding = true;

+ params.ignore_missing_frames = true;

web_contents_->GenerateMHTML(

params,

« no previous file with comments | « no previous file | content/browser/download/mhtml_generation_browsertest.cc » ('j') | no next file with comments »