chrome/browser/ui/app_list/arc/arc_app_item.cc - Issue 2540433002: Reland "Propagate information about how ARC apps are launched"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_item.cc

Issue 2540433002: Reland "Propagate information about how ARC apps are launched" (Closed)

Patch Set: Fixed use-after-free Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/arc/arc_app_item.cc

diff --git a/chrome/browser/ui/app_list/arc/arc_app_item.cc b/chrome/browser/ui/app_list/arc/arc_app_item.cc

index 881aba3ce7af440066a59cbbe3ec64cf3cacf29f..295c7c68a20381bc80da8337fe3be8ec9d1b7088 100644

--- a/chrome/browser/ui/app_list/arc/arc_app_item.cc

+++ b/chrome/browser/ui/app_list/arc/arc_app_item.cc

@@ -46,7 +46,7 @@ const char* ArcAppItem::GetItemType() const {

}

void ArcAppItem::Activate(int event_flags) {

- if (!arc::LaunchApp(profile(), id()))

+ if (!arc::LaunchApp(profile(), id(), event_flags))

return;

// Manually close app_list view because focus is not changed on ARC app start,