Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2540413003: Mus: DirectOutputSurface* => DisplayOutputSurface* (Closed)

Created:
4 years ago by Fady Samuel
Modified:
4 years ago
Reviewers:
rjkroege
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus: DirectOutputSurface* => DisplayOutputSurface* Minor rename: the term "direct" no longer makes sense post-CompositorFrameSink refactor. OutputSurfaces should always be direct once MusBrowserCompositorOutputSurface goes away. "Display"OutputSurface* better capture what these things do. BUG=657888 Committed: https://crrev.com/e3641f984e01d906685f8d861e5f519bc346f5cc Cr-Commit-Position: refs/heads/master@{#435807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -527 lines) Patch
M services/ui/surfaces/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
D services/ui/surfaces/direct_output_surface.h View 1 chunk +0 lines, -65 lines 0 comments Download
D services/ui/surfaces/direct_output_surface.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D services/ui/surfaces/direct_output_surface_ozone.h View 1 chunk +0 lines, -94 lines 0 comments Download
D services/ui/surfaces/direct_output_surface_ozone.cc View 1 chunk +0 lines, -175 lines 0 comments Download
A + services/ui/surfaces/display_output_surface.h View 5 chunks +7 lines, -9 lines 0 comments Download
A + services/ui/surfaces/display_output_surface.cc View 5 chunks +24 lines, -25 lines 0 comments Download
A + services/ui/surfaces/display_output_surface_ozone.h View 5 chunks +7 lines, -8 lines 0 comments Download
A + services/ui/surfaces/display_output_surface_ozone.cc View 7 chunks +24 lines, -24 lines 0 comments Download
M services/ui/surfaces/gpu_compositor_frame_sink.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Fady Samuel
4 years ago (2016-12-01 21:15:18 UTC) #3
rjkroege
lgtm
4 years ago (2016-12-02 00:08:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540413003/1
4 years ago (2016-12-02 01:25:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 01:31:12 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 01:34:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3641f984e01d906685f8d861e5f519bc346f5cc
Cr-Commit-Position: refs/heads/master@{#435807}

Powered by Google App Engine
This is Rietveld 408576698