Move running tasks for fixed time to the scheduler.

Move running tasks for fixed time to the scheduler.

This improves recovery time for change/undo from 300 ms to 200 ms for
analyzer + analysis_server + front_end.

_FilesReferencingNameTask does not degrade in any noticeble way, it is
still about 0-1 ms for this code base, as compared to 60 ms without
fixing runing time in the task or the scheduler.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/53b04631bc2f5572e194138fca44aa7c2c617c98

[Paul Berry, 2016-12-01 13:44:13]

lgtm

[Brian Wilkerson, 2016-12-01 14:36:38]

lgtm

https://codereview.chromium.org/2540403002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2540403002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:996: if
(timer.elapsedMilliseconds > 2) {
I think it would be a good thing to define some constants for the values used to
control this code, moving the comments above into the comments for the
constants, so that we could more easily find where to change the code in order
to experiment with optimizing these values.

[scheglov, 2016-12-01 16:55:06]

PTAL

https://codereview.chromium.org/2540403002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2540403002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:996: if
(timer.elapsedMilliseconds > 2) {
On 2016/12/01 14:36:38, Brian Wilkerson wrote:
> I think it would be a good thing to define some constants for the values used
to
> control this code, moving the comments above into the comments for the
> constants, so that we could more easily find where to change the code in order
> to experiment with optimizing these values.

Done.

[Paul Berry, 2016-12-01 17:10:51]

lgtm

[Brian Wilkerson, 2016-12-01 17:12:28]

lgtm, thanks!

https://codereview.chromium.org/2540403002/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2540403002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/analysis/driver.dart:924: * Relinquishing execution
flow and running event loop after every task has
"running event" --> "running the event"

[scheglov, 2016-12-01 17:15:41]

Description was changed from

==========
Move running tasks for fixed time to the scheduler.

This improves recovery time for change/undo from 300 ms to 200 ms for
analyzer + analysis_server + front_end.

_FilesReferencingNameTask does not degrade in any noticeble way, it is
still about 0-1 ms for this code base, as compared to 60 ms without
fixing runing time in the task or the scheduler.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Move running tasks for fixed time to the scheduler.

This improves recovery time for change/undo from 300 ms to 200 ms for
analyzer + analysis_server + front_end.

_FilesReferencingNameTask does not degrade in any noticeble way, it is
still about 0-1 ms for this code base, as compared to 60 ms without
fixing runing time in the task or the scheduler.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/53b04631bc2f5572e194138fca44aa7c2c617c98
==========

[scheglov, 2016-12-01 17:15:44]

Committed patchset #2 (id:20001) manually as
53b04631bc2f5572e194138fca44aa7c2c617c98 (presubmit successful).