Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2540383003: Don't store git commit in observatory version string (Closed)

Created:
4 years ago by sortie
Modified:
4 years ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, Cutch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't store git commit in observatory version string The observatory assets tarball would be different every time due to the version string, which makes it compress to a different size. The size changes would then move the program data around, making it much more difficult to determine if dart builds of different revisions are actually identical. Google Analytics doesn't need to know the exact version numbers, it will be fine to say they are bleeding edge builds of a particular version. BUG= R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/c0172aba48339e6748cf699c73cbf38943f61616

Patch Set 1 : Don't store git commit in observatory version string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/observatory_tool.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/utils.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
Bill Hesse
LGTM.
4 years ago (2016-12-01 13:13:23 UTC) #4
sortie
4 years ago (2016-12-01 13:16:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
c0172aba48339e6748cf699c73cbf38943f61616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698