Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2540373003:
[ios] Improved GetIndexForOffset performance to large offsets. (Closed)
|
Created:
4 years ago by Eugene But (OOO till 7-30) Modified:
4 years ago Reviewers:
kkhorimoto CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/pending/branch-heads/2924 Project:
chromium Visibility:
Public. |
Description[ios] Improved GetIndexForOffset performance to large offsets.
The difference from trunk CL is allowing integer overflows, which is not
a big issue in practice.
BUG=668318
Trunk CL: https://codereview.chromium.org/2526093002/
NOTRY=true
NOPRESUBMIT=true
Patch Set 1 #Patch Set 2 : Fixed compilation #Patch Set 3 : Fixed test #Messages
Total messages: 18 (12 generated)
The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run
eugenebut@chromium.org changed reviewers: + kkhorimoto@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== [ios] Improved GetIndexForOffset performance to large offsets. The difference from trunk CL is allowing integer overflows, which is not a big issue in practice. BUG=668318 Trunk CL: https://codereview.chromium.org/2526093002/ ========== to ========== [ios] Improved GetIndexForOffset performance to large offsets. The difference from trunk CL is allowing integer overflows, which is not a big issue in practice. BUG=668318 Trunk CL: https://codereview.chromium.org/2526093002/ NOTRY=true and NOPRESUBMIT=true ==========
lgtm
The CQ bit was checked by eugenebut@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== [ios] Improved GetIndexForOffset performance to large offsets. The difference from trunk CL is allowing integer overflows, which is not a big issue in practice. BUG=668318 Trunk CL: https://codereview.chromium.org/2526093002/ NOTRY=true and NOPRESUBMIT=true ========== to ========== [ios] Improved GetIndexForOffset performance to large offsets. The difference from trunk CL is allowing integer overflows, which is not a big issue in practice. BUG=668318 Trunk CL: https://codereview.chromium.org/2526093002/ NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by eugenebut@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480717855003980,
"parent_rev": "319fa5448c9d0545f412644550bb136cc1555536", "commit_rev":
"577a170c43e6a4a80835cd258043debff0ee7aa5"}
Message was sent while issue was closed.
Description was changed from ========== [ios] Improved GetIndexForOffset performance to large offsets. The difference from trunk CL is allowing integer overflows, which is not a big issue in practice. BUG=668318 Trunk CL: https://codereview.chromium.org/2526093002/ NOTRY=true NOPRESUBMIT=true ========== to ========== [ios] Improved GetIndexForOffset performance to large offsets. The difference from trunk CL is allowing integer overflows, which is not a big issue in practice. BUG=668318 Trunk CL: https://codereview.chromium.org/2526093002/ NOTRY=true NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) |
