Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Issue 2540363002: dart2js-kernel: Emit error trap for unimplemented features (Closed)

Created:
4 years ago by sra1
Modified:
4 years ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js-kernel: Emit error trap for unimplemented features The test will fail with an error like the following, rather than proceed with an incorrect null value. R=efortuna@google.com TypeError: Cannot read property 'Unhandled ir.FunctionExpression (dynamic x) → dynamic => x' of null Committed: https://github.com/dart-lang/sdk/commit/ece7725d902b446469fe67ad96f9199543fe504a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
Emily Fortuna
lgtm YAY
4 years ago (2016-12-01 00:51:12 UTC) #4
sra1
4 years ago (2016-12-01 00:52:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ece7725d902b446469fe67ad96f9199543fe504a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698