Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2540333004: Merge to M56: Revert "Toggle spoken feedback if two fingers are held down." (Closed)

Created:
4 years ago by dmazzoni
Modified:
4 years ago
Reviewers:
oshima, sadrul, michaelpg
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge to M56: Revert "Toggle spoken feedback if two fingers are held down." Originally landed in r432129 and r434618. Reverting so we can merge the revert to M56, then will re-land and keep tweaking on trunk. BUG=662501, 667439 TBR=oshima,sadrul,michaelpg CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://chromium.googlesource.com/chromium/src/+/2472b5999c08830451e70d903b49ce3e609cc0de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -528 lines) Patch
M ash/ash_touch_exploration_manager_chromeos.h View 4 chunks +0 lines, -7 lines 0 comments Download
M ash/ash_touch_exploration_manager_chromeos.cc View 2 chunks +1 line, -19 lines 0 comments Download
M ash/common/accessibility_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/default_accessibility_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/default_accessibility_delegate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 2 chunks +0 lines, -12 lines 0 comments Download
D chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_high.wav View Binary file 0 comments Download
D chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_low.wav View Binary file 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chromeos/audio/chromeos_sounds.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/chromeos/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D ui/chromeos/touch_accessibility_enabler.h View 1 chunk +0 lines, -119 lines 0 comments Download
D ui/chromeos/touch_accessibility_enabler.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D ui/chromeos/touch_accessibility_enabler_unittest.cc View 1 chunk +0 lines, -181 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.h View 3 chunks +1 line, -9 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M ui/chromeos/touch_exploration_controller_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
dmazzoni
4 years ago (2016-12-01 21:07:36 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2472b5999c08830451e70d903b49ce3e609cc0de.

Powered by Google App Engine
This is Rietveld 408576698