Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2540333002: cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex (Closed)

Created:
4 years ago by ajuma
Modified:
4 years ago
Reviewers:
jaydasika, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex The map lookup was added by http://crrev.com/434349, but caused a 5-10% regression in CalcDrawPropsTests cc_perftests. This CL sets the effect tree index on the surface during the surface update step (when EffectNode::render_surface gets updated). BUG=670074 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/2d1272d61ee51ba2e2171c77c3cc4545cd288d99 Cr-Commit-Position: refs/heads/master@{#435672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M cc/layers/render_surface_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/layers/render_surface_impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M cc/layers/render_surface_unittest.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
ajuma
4 years ago (2016-11-30 23:59:31 UTC) #9
jaydasika
lgtm
4 years ago (2016-12-01 02:15:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540333002/1
4 years ago (2016-12-01 19:13:42 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 19:19:38 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2d1272d61ee51ba2e2171c77c3cc4545cd288d99 Cr-Commit-Position: refs/heads/master@{#435672}
4 years ago (2016-12-01 19:23:49 UTC) #17
ajuma
4 years ago (2016-12-02 15:41:54 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2544063003/ by ajuma@chromium.org.

The reason for reverting is: This is causing crashes: http://crbug.com/670679.

Powered by Google App Engine
This is Rietveld 408576698