Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2540323005: Decorate mixin application class name with private keys of libraries of super (Closed)

Created:
4 years ago by regis
Modified:
4 years ago
Reviewers:
hausner, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Decorate mixin application class name with private keys of libraries of super type and mixin types if they are imported from a different library than the library defining the mixin application class (fixes #27957). R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/3276a2ea26d67f251f9cc3b42a71a58e82c313cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -7 lines) Patch
M runtime/vm/class_finalizer.cc View 5 chunks +36 lines, -7 lines 0 comments Download
A tests/language/regress_27957_lib1.dart View 1 chunk +9 lines, -0 lines 0 comments Download
A tests/language/regress_27957_lib2.dart View 1 chunk +9 lines, -0 lines 0 comments Download
A tests/language/regress_27957_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
Unfortunately, this does not fix #27760.
4 years ago (2016-12-02 01:08:10 UTC) #2
hausner
LGTM
4 years ago (2016-12-02 05:17:45 UTC) #3
regis
4 years ago (2016-12-02 16:46:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3276a2ea26d67f251f9cc3b42a71a58e82c313cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698