Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2540303002:
Downgrade CHECK added for failing PostTask (Closed)
DescriptionDowngrade CHECK to LOG(WARNING) for failing PostTask
The PostTask on the IOThread seems to fail when the process is being
shutdown. I've checked the instances of the crashes and it appears to be
when ~ChildProcess is on the main thread stack so this check can be
removed as it was added to figure out causes of hung renderers.
BUG=669381
Committed: https://crrev.com/4c59bcdfbe12d79aaff6048cba0c184c152348c2
Cr-Commit-Position: refs/heads/master@{#435447}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Downgrade CHECK added for failing PostTask to LOG(WARNING) #Messages
Total messages: 19 (12 generated)
Description was changed from ========== Remove CHECK added for failing PostTask The PostTask on the IOThread seems to fail when the process is being shutdown. I've checked the instances of the crashes and it appears to be when ~ChildProcess is on the main thread stack so this check can be removed as it was added to figure out causes of hung renderers. BUG=669381 ========== to ========== Remove CHECK added for failing PostTask The PostTask on the IOThread seems to fail when the process is being shutdown. I've checked the instances of the crashes and it appears to be when ~ChildProcess is on the main thread stack so this check can be removed as it was added to figure out causes of hung renderers. BUG=669381 ==========
dtapuska@chromium.org changed reviewers: + mustaq@chromium.org
The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2540303002/diff/1/content/renderer/input/inpu... File content/renderer/input/input_event_filter.cc (left): https://codereview.chromium.org/2540303002/diff/1/content/renderer/input/inpu... content/renderer/input/input_event_filter.cc:185: << "PostTask failed"; May be still emit a message, w/o the check.
Description was changed from ========== Remove CHECK added for failing PostTask The PostTask on the IOThread seems to fail when the process is being shutdown. I've checked the instances of the crashes and it appears to be when ~ChildProcess is on the main thread stack so this check can be removed as it was added to figure out causes of hung renderers. BUG=669381 ========== to ========== Downgrade CHECK to LOG(WARNING) for failing PostTask The PostTask on the IOThread seems to fail when the process is being shutdown. I've checked the instances of the crashes and it appears to be when ~ChildProcess is on the main thread stack so this check can be removed as it was added to figure out causes of hung renderers. BUG=669381 ==========
On 2016/11/30 21:21:25, mustaq wrote: > https://codereview.chromium.org/2540303002/diff/1/content/renderer/input/inpu... > File content/renderer/input/input_event_filter.cc (left): > > https://codereview.chromium.org/2540303002/diff/1/content/renderer/input/inpu... > content/renderer/input/input_event_filter.cc:185: << "PostTask failed"; > May be still emit a message, w/o the check. done
The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by dtapuska@chromium.org
The CQ bit was checked by dtapuska@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480542360117390,
"parent_rev": "bfb9c1694b277a790c2c0269d8254731341d0753", "commit_rev":
"a3e90daa4340936a8bab8ede1676f938fb8719e6"}
Message was sent while issue was closed.
Description was changed from ========== Downgrade CHECK to LOG(WARNING) for failing PostTask The PostTask on the IOThread seems to fail when the process is being shutdown. I've checked the instances of the crashes and it appears to be when ~ChildProcess is on the main thread stack so this check can be removed as it was added to figure out causes of hung renderers. BUG=669381 ========== to ========== Downgrade CHECK to LOG(WARNING) for failing PostTask The PostTask on the IOThread seems to fail when the process is being shutdown. I've checked the instances of the crashes and it appears to be when ~ChildProcess is on the main thread stack so this check can be removed as it was added to figure out causes of hung renderers. BUG=669381 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Downgrade CHECK to LOG(WARNING) for failing PostTask The PostTask on the IOThread seems to fail when the process is being shutdown. I've checked the instances of the crashes and it appears to be when ~ChildProcess is on the main thread stack so this check can be removed as it was added to figure out causes of hung renderers. BUG=669381 ========== to ========== Downgrade CHECK to LOG(WARNING) for failing PostTask The PostTask on the IOThread seems to fail when the process is being shutdown. I've checked the instances of the crashes and it appears to be when ~ChildProcess is on the main thread stack so this check can be removed as it was added to figure out causes of hung renderers. BUG=669381 Committed: https://crrev.com/4c59bcdfbe12d79aaff6048cba0c184c152348c2 Cr-Commit-Position: refs/heads/master@{#435447} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4c59bcdfbe12d79aaff6048cba0c184c152348c2 Cr-Commit-Position: refs/heads/master@{#435447} |
