Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: Source/core/page/Frame.h

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 private: 172 private:
173 Frame(Page*, const Handle<HTMLFrameOwnerElement>&, FrameLoaderClient*); 173 Frame(Page*, const Handle<HTMLFrameOwnerElement>&, FrameLoaderClient*);
174 174
175 HashSet<FrameDestructionObserver*> m_destructionObservers; 175 HashSet<FrameDestructionObserver*> m_destructionObservers;
176 176
177 Page* m_page; 177 Page* m_page;
178 mutable FrameTree m_treeNode; 178 mutable FrameTree m_treeNode;
179 mutable FrameLoader m_loader; 179 mutable FrameLoader m_loader;
180 mutable NavigationScheduler m_navigationScheduler; 180 mutable NavigationScheduler m_navigationScheduler;
181 181
182 // FIXME(oilpan): Move Frame to the heap and use a Member. 182 // FIXME(oilpan): This should be a strong pointer.
183 HTMLFrameOwnerElement* m_ownerElement; 183 HTMLFrameOwnerElement* m_ownerElement;
184 RefPtr<FrameView> m_view; 184 RefPtr<FrameView> m_view;
185 Persistent<Document> m_doc; 185 Persistent<Document> m_doc;
186 186
187 OwnPtr<ScriptController> m_script; 187 OwnPtr<ScriptController> m_script;
188 OwnPtr<Editor> m_editor; 188 OwnPtr<Editor> m_editor;
189 OwnPtr<FrameSelection> m_selection; 189 OwnPtr<FrameSelection> m_selection;
190 OwnPtr<EventHandler> m_eventHandler; 190 OwnPtr<EventHandler> m_eventHandler;
191 OwnPtr<AnimationController> m_animationController; 191 OwnPtr<AnimationController> m_animationController;
192 192
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 } 271 }
272 272
273 inline EventHandler* Frame::eventHandler() const 273 inline EventHandler* Frame::eventHandler() const
274 { 274 {
275 return m_eventHandler.get(); 275 return m_eventHandler.get();
276 } 276 }
277 277
278 } // namespace WebCore 278 } // namespace WebCore
279 279
280 #endif // Frame_h 280 #endif // Frame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698