[oilpan] Figure out lifetime of remaining Node raw pointers (Part 2)

Source/core/dom/CheckedRadioButtons.cpp

 /*
  * Copyright (C) 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 14 matching lines @@
 #include <wtf/HashSet.h>
 
 namespace WebCore {
 
 class RadioButtonGroup {
     WTF_MAKE_FAST_ALLOCATED;
 public:
     static PassOwnPtr<RadioButtonGroup> create();
     bool isEmpty() const { return m_members.isEmpty(); }
     bool isRequired() const { return m_requiredCount; }
-    Result<HTMLInputElement> checkedButton() const { return Handle<HTMLInputElement>(m_checkedButton); } // FIXME(oilpan): Remove Handle<>().
+    Result<HTMLInputElement> checkedButton() const { return adoptRawResult(m_checkedButton); }
     void add(const Handle<HTMLInputElement>&);
     void updateCheckedState(const Handle<HTMLInputElement>&);
     void requiredAttributeChanged(const Handle<HTMLInputElement>&);
     void remove(const Handle<HTMLInputElement>&);
     bool contains(const Handle<HTMLInputElement>&) const;
 
 private:
     RadioButtonGroup();
     void setNeedsValidityCheckForAllButtons();
     bool isValid() const;
     void setCheckedButton(const Handle<HTMLInputElement>&);
 
-    // FIXME(oilpan): Move RadioButtonGroup to the heap and use Members.
+    // FIXME(oilpan): This should be a weak hash set.

[Mads Ager (chromium), 2013/10/01 10:14:55]

I don't think should be weak. These should be strong pointers. These mappings
are explicitly managed independently of object life-time. Objects are removed
from here when removed from the document and otherwise everything dies together.
No need for weak processing.

[haraken, 2013/10/01 16:46:52]

Right. Fixed.

     HashSet<HTMLInputElement*> m_members;
+    // FIXME(oilpan): This should be a weak pointer.
     HTMLInputElement* m_checkedButton;

[zerny-chromium, 2013/10/01 10:18:37]

Why should these be weak pointers?

[haraken, 2013/10/01 16:46:52]

Right. This should be a strong pointer. Thanks.

     size_t m_requiredCount;
 };
 
 RadioButtonGroup::RadioButtonGroup()
     : m_checkedButton(0)
     , m_requiredCount(0)
 {
 }
 
 PassOwnPtr<RadioButtonGroup> RadioButtonGroup::create()
 {
     return adoptPtr(new RadioButtonGroup);
 }
 
 inline bool RadioButtonGroup::isValid() const
 {
     return !isRequired() || m_checkedButton;
 }
 
 void RadioButtonGroup::setCheckedButton(const Handle<HTMLInputElement>& button)
 {
-    Handle<HTMLInputElement> oldCheckedButton = Handle<HTMLInputElement>(m_checkedButton); // FIXME(oilpan): Remove Handle<>().
+    Handle<HTMLInputElement> oldCheckedButton = adoptRawResult(m_checkedButton);
     if (oldCheckedButton == button)
         return;
     m_checkedButton = button.raw();
     if (oldCheckedButton)
         oldCheckedButton->setChecked(false);
 }
 
 void RadioButtonGroup::add(const Handle<HTMLInputElement>& button)
 {
     ASSERT(button->isRadioButton());
@@ skipping 179 matching lines @@
         // FIXME: We may skip deallocating the empty RadioButtonGroup for
         // performance improvement. If we do so, we need to change the key type
         // of m_nameToGroupMap from AtomicStringImpl* to RefPtr<AtomicStringImpl>.
         m_nameToGroupMap->remove(it);
         if (m_nameToGroupMap->isEmpty())
             m_nameToGroupMap.clear();
     }
 }
 
 } // namespace