Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: Source/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007-2009 Google Inc. All rights reserved. 2 * Copyright (C) 2007-2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 29 matching lines...) Expand all
40 #include "core/page/Frame.h" 40 #include "core/page/Frame.h"
41 41
42 #include "V8DOMWindow.h" 42 #include "V8DOMWindow.h"
43 #include "bindings/v8/V8Binding.h" 43 #include "bindings/v8/V8Binding.h"
44 44
45 namespace WebCore { 45 namespace WebCore {
46 46
47 v8::Handle<v8::Value> V8HTMLFrameSetElement::namedPropertyGetter(v8::Local<v8::S tring> name, const v8::AccessorInfo& info) 47 v8::Handle<v8::Value> V8HTMLFrameSetElement::namedPropertyGetter(v8::Local<v8::S tring> name, const v8::AccessorInfo& info)
48 { 48 {
49 HandleScope handleScope; 49 HandleScope handleScope;
50 HTMLFrameSetElement* imp = V8HTMLFrameSetElement::toNative(info.Holder()); 50 Handle<HTMLFrameSetElement> imp = adoptRawResult(V8HTMLFrameSetElement::toNa tive(info.Holder()));
51 Handle<Node> frameNode = imp->children()->namedItem(toWebCoreAtomicString(na me)); 51 Handle<Node> frameNode = imp->children()->namedItem(toWebCoreAtomicString(na me));
52 if (!frameNode) 52 if (!frameNode)
53 return v8Undefined(); 53 return v8Undefined();
54 if (!frameNode->hasTagName(HTMLNames::frameTag)) 54 if (!frameNode->hasTagName(HTMLNames::frameTag))
55 return v8Undefined(); 55 return v8Undefined();
56 Handle<Document> document = Handle<HTMLFrameElement>::cast(frameNode)->conte ntDocument(); 56 Handle<Document> document = Handle<HTMLFrameElement>::cast(frameNode)->conte ntDocument();
57 if (!document) 57 if (!document)
58 return v8Undefined(); 58 return v8Undefined();
59 if (!document->frame()) 59 if (!document->frame())
60 return v8Undefined(); 60 return v8Undefined();
61 return toV8Fast(document->domWindow(), info, imp); 61 return toV8Fast(document->domWindow(), info, imp.raw());
62 } 62 }
63 63
64 } // namespace WebCore 64 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698