Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2540243003: Fix privacy whitepaper link on safe browsing blocking page and captive (Closed)

Created:
4 years ago by Jialiu Lin
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix privacy whitepaper link on safe browsing blocking page and captive portal bloking page (whitepaper links on other interstitials are fine). Link privacy whitepaper to "system information and page content" instead of "Automatically send" on Scout opt-in string. BUG=667823, 667385 Review-Url: https://codereview.chromium.org/2526543002 Cr-Commit-Position: refs/heads/master@{#434546} (cherry picked from commit 762fb54cd325ae2f557a3a8f9199daa480f8f8b7) Committed: https://chromium.googlesource.com/chromium/src/+/ff1ef44692a1b71e31d366790ad8cd3abf3615ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ssl/captive_portal_blocking_page.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Jialiu Lin
4 years ago (2016-11-30 22:56:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ff1ef44692a1b71e31d366790ad8cd3abf3615ca.

Powered by Google App Engine
This is Rietveld 408576698