Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2540233005: Don't dispatch vrdisplayactivate event if the page that listens for it is invisible (Closed)

Created:
4 years ago by bshe
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Don't dispatch vrdisplayactivate event if the page that listens for it is invisible BUG=669190 Review-Url: https://codereview.chromium.org/2539763004 Cr-Commit-Position: refs/heads/master@{#435500} (cherry picked from commit af675fa58d6a3557a6704a9faeac8012dc360209) Committed: https://chromium.googlesource.com/chromium/src/+/4d33ff01c14f51fe6325f8033e002bd4b7e3a9a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 4 chunks +19 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.h View 4 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
bshe
4 years ago (2016-12-01 20:11:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d33ff01c14f51fe6325f8033e002bd4b7e3a9a7.

Powered by Google App Engine
This is Rietveld 408576698