Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 254023002: Add a UseCounter for Notification.permission (Closed)

Created:
6 years, 7 months ago by Peter Beverloo
Modified:
6 years, 7 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Add a UseCounter for Notification.permission While this is a relatively new property, it does require a synchronous IPC to the browser process in order to get the permission status, and thus would be better as a Notification.hasPermission() method returning a Promise (or similar). Since we will need a similar construct for Push Messaging, and potentially other APIs, let's get some data on whether developers use this to see if we can get a more common, asynchronous approach. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173004

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Peter Beverloo
6 years, 7 months ago (2014-04-29 16:46:01 UTC) #1
abarth-chromium
lgtm
6 years, 7 months ago (2014-04-29 19:32:22 UTC) #2
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 7 months ago (2014-04-29 19:34:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/254023002/1
6 years, 7 months ago (2014-04-29 19:35:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 04:47:06 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-04-30 04:47:06 UTC) #6
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 7 months ago (2014-04-30 13:58:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/254023002/20001
6 years, 7 months ago (2014-04-30 13:58:35 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 14:16:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink
6 years, 7 months ago (2014-04-30 14:16:07 UTC) #10
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 7 months ago (2014-04-30 16:08:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/254023002/20001
6 years, 7 months ago (2014-04-30 16:08:59 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 17:15:38 UTC) #13
Message was sent while issue was closed.
Change committed as 173004

Powered by Google App Engine
This is Rietveld 408576698