Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2540193002: [ObjC ARC] Converts ios/chrome/browser/favicon:favicon to ARC.Automatically generated ARCMigrate … (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), browser-components-watch_chromium.org, mac-reviews_chromium.org, sdefresne+watch_chromium.org, gambard
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/favicon:favicon to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/ceeb3ad466125bda4c5ed64e6572c8036eff7481 Cr-Commit-Position: refs/heads/master@{#435912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M ios/chrome/browser/favicon/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/favicon/favicon_attributes.mm View 3 chunks +12 lines, -12 lines 0 comments Download
M ios/chrome/browser/favicon/favicon_attributes_provider.mm View 2 chunks +5 lines, -1 line 0 comments Download
M ios/chrome/browser/favicon/favicon_client_impl.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/favicon/favicon_loader.h View 2 chunks +1 line, -2 lines 0 comments Download
M ios/chrome/browser/favicon/favicon_loader.mm View 2 chunks +8 lines, -6 lines 0 comments Download
M ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL. CC Gauthier FYI
4 years ago (2016-12-01 10:06:09 UTC) #6
noyau (Ping after 24h)
lgtm
4 years ago (2016-12-01 11:11:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540193002/1
4 years ago (2016-12-02 10:16:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 11:20:31 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 11:23:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ceeb3ad466125bda4c5ed64e6572c8036eff7481
Cr-Commit-Position: refs/heads/master@{#435912}

Powered by Google App Engine
This is Rietveld 408576698