Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2540173002: Attempt to deflake coords-dom-02-f.svg (Closed)

Created:
4 years ago by f(malita)
Modified:
4 years ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to deflake coords-dom-02-f.svg The test is currently changing style without synchronizing with the harness. This CL is trying to addres that, speculatively. BUG=669643 R=wangxianzhu@chromium.org Committed: https://crrev.com/a0e1286887eb8da26ce82e12291484fb76a537d6 Cr-Commit-Position: refs/heads/master@{#435375}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg View 1 1 chunk +25 lines, -22 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
f(malita)
4 years ago (2016-11-30 14:45:22 UTC) #4
Xianzhu
lgtm https://codereview.chromium.org/2540173002/diff/1/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg File third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg (right): https://codereview.chromium.org/2540173002/diff/1/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg#newcode60 third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg:60: testRunner.waitUntilDone(); Nit: The above two lines can be ...
4 years ago (2016-11-30 17:08:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540173002/1
4 years ago (2016-11-30 17:09:24 UTC) #7
f(malita)
https://codereview.chromium.org/2540173002/diff/1/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg File third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg (right): https://codereview.chromium.org/2540173002/diff/1/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg#newcode60 third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg:60: testRunner.waitUntilDone(); On 2016/11/30 17:08:54, Xianzhu wrote: > Nit: The ...
4 years ago (2016-11-30 18:08:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540173002/20001
4 years ago (2016-11-30 18:09:17 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 19:28:30 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-30 19:33:03 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0e1286887eb8da26ce82e12291484fb76a537d6
Cr-Commit-Position: refs/heads/master@{#435375}

Powered by Google App Engine
This is Rietveld 408576698