Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2540163002: WebView: Cleanup class/struct forward declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
Reviewers:
Torne
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebView: Cleanup class/struct forward declarations Remove useless class and struct forward declarations, and add missing ones in android_webview header files. BUG=662195 Committed: https://crrev.com/51f0dc6ccc9836e4afa5fde2fa76113afeef29f3 Cr-Commit-Position: refs/heads/master@{#435590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M android_webview/browser/aw_browser_main_parts.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/aw_contents_io_thread_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/aw_metrics_service_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/browser_view_renderer_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/hardware_renderer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/net/aw_network_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/net/aw_web_resource_response.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/net/init_native_callback.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/renderer_host/aw_render_view_host_ext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/scoped_app_gl_state_restore.h View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/browser/surfaces_instance.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/test/rendering_test.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/native/android_protocol_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/native/aw_autofill_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/native/aw_contents.h View 2 chunks +0 lines, -2 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M android_webview/native/aw_quota_manager_bridge_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/native/aw_web_contents_view_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/native/aw_web_preferences_populater_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jbriance
4 years ago (2016-11-30 14:02:11 UTC) #2
Torne
lgtm
4 years ago (2016-12-01 10:25:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540163002/1
4 years ago (2016-12-01 10:27:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 10:49:41 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-01 10:51:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51f0dc6ccc9836e4afa5fde2fa76113afeef29f3
Cr-Commit-Position: refs/heads/master@{#435590}

Powered by Google App Engine
This is Rietveld 408576698