Issue 2540143004: Prevent a crash if the window was deleted while in a drag runloop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2540143004: Prevent a crash if the window was deleted while in a drag runloop (Closed)

Created:
4 years ago by afakhry

Modified:
4 years ago

Reviewers:
oshima

CC:
chromium-reviews, kalyank, sadrul

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Prevent a crash if the window was deleted while in a drag runloop The CL https://codereview.chromium.org/2494713003/ caused a crash in WorkspaceEventHandlerTest.DeleteWhileInRunLoop. This CL adds a tracker for the window deletion. BUG=626761 TEST=ash_unittests --gtest_filter=WorkspaceEventHandlerTest.DeleteWhileInRunLoop

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	ash/wm/toplevel_window_event_handler.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages