Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2540143002:
Enable per thread heap on parser thread (Closed)
DescriptionEnable per thread heap on parser thread
BUG=591606
Committed: https://crrev.com/3e7fe3520659860b931521884673f5ecf68c21e0
Cr-Commit-Position: refs/heads/master@{#435578}
Patch Set 1 #
Messages
Total messages: 19 (14 generated)
The CQ bit was checked by keishi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by keishi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
keishi@chromium.org changed reviewers: + haraken@chromium.org, oilpan-reviews@chromium.org
I searched through the code but BackgroundHTMLParser and HTMLDocumentParser are the only on heap references that the HTMLParserThread accesses, and both references are WeakPtr instead of oilpan handles so I think they should be ok.
Description was changed from ========== Enable per thread heap on parser thread BUG= ========== to ========== Enable per thread heap on parser thread BUG= 591606 ==========
On 2016/12/01 06:25:48, keishi wrote: > I searched through the code but BackgroundHTMLParser and HTMLDocumentParser are > the only on heap references that the HTMLParserThread accesses, and both > references are WeakPtr instead of oilpan handles so I think they should be ok. Ideally we want to remove the WeakPtrs but that's another story. LGTM.
The CQ bit was checked by keishi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480579186941230, "parent_rev":
"3f167f08aa9ade4cf2d8797ceeef99be78344852", "commit_rev":
"72ae7c2a71e7afb650f73ccdefbae9fd50bf9e83"}
Message was sent while issue was closed.
Description was changed from ========== Enable per thread heap on parser thread BUG= 591606 ========== to ========== Enable per thread heap on parser thread BUG= 591606 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable per thread heap on parser thread BUG= 591606 ========== to ========== Enable per thread heap on parser thread BUG= 591606 Committed: https://crrev.com/3e7fe3520659860b931521884673f5ecf68c21e0 Cr-Commit-Position: refs/heads/master@{#435578} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3e7fe3520659860b931521884673f5ecf68c21e0 Cr-Commit-Position: refs/heads/master@{#435578} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
