[wasm] Remove raw byte pointers from WasmModule

src/wasm/wasm-text.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/wasm/wasm-text.h"
 
 #include "src/ostreams.h"
 #include "src/vector.h"
 #include "src/wasm/ast-decoder.h"
 #include "src/wasm/wasm-module.h"
@@ skipping 110 matching lines @@
     bool valid_char = (c >= '0' && c <= '9') || (c >= 'a' && c <= 'z') ||
                       (c >= 'A' && c <= 'Z') || strchr(special_chars, c);
     if (!valid_char) return false;
   }
   return true;
 }
 
 }  // namespace
 
 void wasm::PrintWasmText(
-    const WasmModule *module, uint32_t func_index, std::ostream &os,
+    const WasmModule *module, const ModuleWireBytes &wire_bytes,
+    uint32_t func_index, std::ostream &os,
     std::vector<std::tuple<uint32_t, int, int>> *offset_table) {
   DCHECK_NOT_NULL(module);
   DCHECK_GT(module->functions.size(), func_index);
   const WasmFunction *fun = &module->functions[func_index];
 
   AccountingAllocator allocator;
   Zone zone(&allocator, ZONE_NAME);
   int line_nr = 0;
   int control_depth = 0;
 
   // Print the function signature.
   os << "func";
-  Vector<const char> fun_name(
-      reinterpret_cast<const char *>(module->module_start + fun->name_offset),
-      fun->name_length);
+  WasmName fun_name = wire_bytes.GetNameOrNull(fun);
   if (IsValidFunctionName(fun_name)) {
     os << " $";
     os.write(fun_name.start(), fun_name.length());
   }
   size_t param_count = fun->sig->parameter_count();
   if (param_count) {
     os << " (param";
     for (size_t i = 0; i < param_count; ++i)
       os << ' ' << WasmOpcodes::TypeName(fun->sig->GetParam(i));
     os << ')';
   }
   size_t return_count = fun->sig->return_count();
   if (return_count) {
     os << " (result";
     for (size_t i = 0; i < return_count; ++i)
       os << ' ' << WasmOpcodes::TypeName(fun->sig->GetReturn(i));
     os << ')';
   }
   os << "\n";
   ++line_nr;
 
   // Print the local declarations.
   AstLocalDecls decls(&zone);
-  const byte *code_start = module->module_start + fun->code_start_offset;
-  const byte *code_end = module->module_start + fun->code_end_offset;
-  BytecodeIterator i(code_start, code_end, &decls);
-  DCHECK_LT(code_start, i.pc());
+  Vector<const byte> func_bytes = wire_bytes.module_bytes.SubVector(
+      fun->code_start_offset, fun->code_end_offset);
+  BytecodeIterator i(func_bytes.begin(), func_bytes.end(), &decls);
+  DCHECK_LT(func_bytes.begin(), i.pc());
   if (!decls.local_types.empty()) {
     os << "(local";
     for (auto p : decls.local_types) {
       for (unsigned i = 0; i < p.second; ++i)
         os << ' ' << WasmOpcodes::TypeName(p.first);
     }
     os << ")\n";
     ++line_nr;
   }
 
@@ skipping 118 matching lines @@
       default:
         UNREACHABLE();
         break;
     }
     os << '\n';
     ++line_nr;
   }
   DCHECK_EQ(0, control_depth);
   DCHECK(i.ok());
 }