Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2540053002: Justify the message center to the right of the screen (i.e. the same (Closed)

Created:
4 years ago by Evan Stade
Modified:
4 years ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Justify the message center to the right of the screen (i.e. the same place as the system menu). BUG=666625 Committed: https://crrev.com/cda46b04bb3184f699ad9dd44dcebe94fd6f5a59 Cr-Commit-Position: refs/heads/master@{#435733}

Patch Set 1 #

Total comments: 2

Patch Set 2 : shelf alignment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M ash/common/system/web_notification/web_notification_tray.cc View 1 4 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Evan Stade
4 years ago (2016-11-30 01:33:50 UTC) #2
tdanderson
https://codereview.chromium.org/2540053002/diff/1/ash/common/system/web_notification/web_notification_tray.cc File ash/common/system/web_notification/web_notification_tray.cc (right): https://codereview.chromium.org/2540053002/diff/1/ash/common/system/web_notification/web_notification_tray.cc#newcode382 ash/common/system/web_notification/web_notification_tray.cc:382: if (GetAnchorAlignment() == views::TrayBubbleView::ANCHOR_ALIGNMENT_BOTTOM) { Don't you mean to ...
4 years ago (2016-11-30 01:51:37 UTC) #3
Evan Stade
https://codereview.chromium.org/2540053002/diff/1/ash/common/system/web_notification/web_notification_tray.cc File ash/common/system/web_notification/web_notification_tray.cc (right): https://codereview.chromium.org/2540053002/diff/1/ash/common/system/web_notification/web_notification_tray.cc#newcode382 ash/common/system/web_notification/web_notification_tray.cc:382: if (GetAnchorAlignment() == views::TrayBubbleView::ANCHOR_ALIGNMENT_BOTTOM) { On 2016/11/30 01:51:37, tdanderson ...
4 years ago (2016-11-30 23:56:47 UTC) #4
tdanderson
LGTM
4 years ago (2016-12-01 20:58:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540053002/20001
4 years ago (2016-12-01 21:59:57 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 22:06:46 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 22:08:55 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cda46b04bb3184f699ad9dd44dcebe94fd6f5a59
Cr-Commit-Position: refs/heads/master@{#435733}

Powered by Google App Engine
This is Rietveld 408576698