Issue 254003: Refactored event handler method bodies from widget_win.h to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254003: Refactored event handler method bodies from widget_win.h to... (Closed)

Created:
11 years, 2 months ago by Ken Russell (Google)

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit), Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Refactored event handler method bodies from widget_win.h to widget_win.cc. This significantly reduces build times when modifying the code of these event handlers during debugging. BUG=http://code.google.com/p/chromium/issues/detail?id=23274 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27435

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -99 lines)			Patch
	M	views/widget/widget_win.h	View	1	5 chunks	+38 lines, -99 lines	0 comments	Download
	M	views/widget/widget_win.cc	View	1 2	11 chunks	+165 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

OK http://codereview.chromium.org/254003/diff/1/2 File views/widget/widget_win.cc (right): http://codereview.chromium.org/254003/diff/1/2#newcode472 Line 472: LRESULT WidgetWin::OnCreate(LPCREATESTRUCT create_struct) { can we change ...

11 years, 2 months ago (2009-09-28 21:25:11 UTC) #2

Ken Russell (switch to Gerrit)

11 years, 2 months ago (2009-09-28 21:51:05 UTC) #3

http://codereview.chromium.org/254003/diff/1/2
File views/widget/widget_win.cc (right):

http://codereview.chromium.org/254003/diff/1/2#newcode472
Line 472: LRESULT WidgetWin::OnCreate(LPCREATESTRUCT create_struct) {
On 2009/09/28 21:25:11, Ben Goodger wrote:
> can we change this to just CREATESTRUCT*?

Done.

Expand Messages | Collapse Messages