Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: content/child/shared_memory_received_data_factory_unittest.cc

Issue 2540023003: Dispatch encoded_data_length separately in content/child (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/shared_memory_received_data_factory_unittest.cc
diff --git a/content/child/shared_memory_received_data_factory_unittest.cc b/content/child/shared_memory_received_data_factory_unittest.cc
index 65bad7c837a2affaa840a97c05e0d5697e63889c..d2258a10ceeb3b7730e386f9fd34e94edd7b25da 100644
--- a/content/child/shared_memory_received_data_factory_unittest.cc
+++ b/content/child/shared_memory_received_data_factory_unittest.cc
@@ -72,13 +72,12 @@ TEST_F(SharedMemoryReceivedDataFactoryTest, Create) {
EXPECT_CALL(*sender_, SendAck(request_id_));
EXPECT_CALL(checkpoint, Call(1));
- std::unique_ptr<ReceivedData> data = factory_->Create(12, 34, 56);
+ std::unique_ptr<ReceivedData> data = factory_->Create(12, 34);
const char* memory_start = static_cast<const char*>(memory_->memory());
ASSERT_TRUE(data);
EXPECT_EQ(memory_start + 12, data->payload());
EXPECT_EQ(34, data->length());
- EXPECT_EQ(56, data->encoded_data_length());
checkpoint.Call(0);
data.reset();
@@ -96,9 +95,9 @@ TEST_F(SharedMemoryReceivedDataFactoryTest, CreateMultiple) {
EXPECT_CALL(*sender_, SendAck(request_id_));
EXPECT_CALL(checkpoint, Call(3));
- std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1, 1);
- std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1, 1);
- std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1, 1);
+ std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1);
+ std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1);
+ std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1);
EXPECT_TRUE(data1);
EXPECT_TRUE(data2);
@@ -124,9 +123,9 @@ TEST_F(SharedMemoryReceivedDataFactoryTest, ReclaimOutOfOrder) {
EXPECT_CALL(*sender_, SendAck(request_id_));
EXPECT_CALL(checkpoint, Call(3));
- std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1, 1);
- std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1, 1);
- std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1, 1);
+ std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1);
+ std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1);
+ std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1);
EXPECT_TRUE(data1);
EXPECT_TRUE(data2);
@@ -156,12 +155,12 @@ TEST_F(SharedMemoryReceivedDataFactoryTest, ReclaimOutOfOrderPartially) {
EXPECT_CALL(*sender_, SendAck(request_id_));
EXPECT_CALL(checkpoint, Call(4));
- std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1, 1);
- std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1, 1);
- std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1, 1);
- std::unique_ptr<ReceivedData> data4 = factory_->Create(3, 1, 1);
- std::unique_ptr<ReceivedData> data5 = factory_->Create(4, 1, 1);
- std::unique_ptr<ReceivedData> data6 = factory_->Create(5, 1, 1);
+ std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1);
+ std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1);
+ std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1);
+ std::unique_ptr<ReceivedData> data4 = factory_->Create(3, 1);
+ std::unique_ptr<ReceivedData> data5 = factory_->Create(4, 1);
+ std::unique_ptr<ReceivedData> data6 = factory_->Create(5, 1);
EXPECT_TRUE(data1);
EXPECT_TRUE(data2);
@@ -194,12 +193,12 @@ TEST_F(SharedMemoryReceivedDataFactoryTest, Stop) {
EXPECT_CALL(checkpoint, Call(2));
EXPECT_CALL(checkpoint, Call(3));
- std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1, 1);
- std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1, 1);
- std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1, 1);
- std::unique_ptr<ReceivedData> data4 = factory_->Create(3, 1, 1);
- std::unique_ptr<ReceivedData> data5 = factory_->Create(4, 1, 1);
- std::unique_ptr<ReceivedData> data6 = factory_->Create(5, 1, 1);
+ std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1);
+ std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1);
+ std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1);
+ std::unique_ptr<ReceivedData> data4 = factory_->Create(3, 1);
+ std::unique_ptr<ReceivedData> data5 = factory_->Create(4, 1);
+ std::unique_ptr<ReceivedData> data6 = factory_->Create(5, 1);
EXPECT_TRUE(data1);
EXPECT_TRUE(data2);

Powered by Google App Engine
This is Rietveld 408576698