Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: content/child/resource_dispatcher_unittest.cc

Issue 2540023003: Dispatch encoded_data_length separately in content/child (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/resource_dispatcher_unittest.cc
diff --git a/content/child/resource_dispatcher_unittest.cc b/content/child/resource_dispatcher_unittest.cc
index 0b4dc7e27b21e9898a51ffc0199decd8991d753e..e44df145c0b91a838657a038b5b6030a07d5355c 100644
--- a/content/child/resource_dispatcher_unittest.cc
+++ b/content/child/resource_dispatcher_unittest.cc
@@ -92,7 +92,6 @@ class TestRequestPeer : public RequestPeer {
EXPECT_TRUE(context_->received_response);
EXPECT_FALSE(context_->complete);
context_->data.append(data->payload(), data->length());
- context_->total_encoded_data_length += data->encoded_data_length();
if (context_->cancel_on_receive_data) {
dispatcher_->Cancel(context_->request_id);
@@ -100,6 +99,12 @@ class TestRequestPeer : public RequestPeer {
}
}
+ void OnTransferSizeUpdated(int transfer_size_diff) override {
+ if (context_->cancelled)
+ return;
+ context_->total_encoded_data_length += transfer_size_diff;
+ }
+
void OnCompletedRequest(int error_code,
bool was_ignored_by_handler,
bool stale_copy_in_cache,
@@ -540,6 +545,7 @@ class TestResourceDispatcherDelegate : public ResourceDispatcherDelegate {
void OnReceivedData(std::unique_ptr<ReceivedData> data) override {
data_.append(data->payload(), data->length());
}
+ void OnTransferSizeUpdated(int transfer_size_diff) override {}
void OnCompletedRequest(int error_code,
bool was_ignored_by_handler,
@@ -549,8 +555,8 @@ class TestResourceDispatcherDelegate : public ResourceDispatcherDelegate {
int64_t encoded_body_size) override {
original_peer_->OnReceivedResponse(response_info_);
if (!data_.empty()) {
- original_peer_->OnReceivedData(base::MakeUnique<FixedReceivedData>(
- data_.data(), data_.size(), -1));
+ original_peer_->OnReceivedData(
+ base::MakeUnique<FixedReceivedData>(data_.data(), data_.size()));
}
original_peer_->OnCompletedRequest(
error_code, was_ignored_by_handler, stale_copy_in_cache,

Powered by Google App Engine
This is Rietveld 408576698