Dispatch encoded_data_length separately in content/child

content/public/child/request_peer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_CHILD_REQUEST_PEER_H_
 #define CONTENT_PUBLIC_CHILD_REQUEST_PEER_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 29 matching lines @@
   // In order to work with Chrome resource loading IPC, it is desirable to
   // reclaim data in FIFO order in a RequestPeer in terms of performance.
   // |payload|, |length|, |encoded_data_length| and |encoded_body_length|
   // functions are thread-safe, but the data object itself must be destroyed on
   // the original thread.
   class CONTENT_EXPORT ReceivedData {
    public:
     virtual ~ReceivedData() {}
     virtual const char* payload() const = 0;
     virtual int length() const = 0;
-    // The encoded_data_length is the length of the encoded data transferred
-    // over the network, including headers. It is only set for responses
-    // originating from the network (ie. not the cache). It will usually be
-    // different from length(), and may be smaller if the content was
-    // compressed. -1 means this value is unavailable.
-    virtual int encoded_data_length() const = 0;
   };
 
   // A ThreadSafeReceivedData can be deleted on ANY thread.
   class CONTENT_EXPORT ThreadSafeReceivedData : public ReceivedData {};
 
   // Called as upload progress is made.
   // note: only for requests with upload progress enabled.
   virtual void OnUploadProgress(uint64_t position, uint64_t size) = 0;
 
   // Called when a redirect occurs.  The implementation may return false to
@@ skipping 13 matching lines @@
   // that case, OnReceivedData will not be called.
   // The encoded_data_length is the length of the encoded data transferred
   // over the network, which could be different from data length (e.g. for
   // gzipped content).
   virtual void OnDownloadedData(int len, int encoded_data_length) = 0;
 
   // Called when a chunk of response data is available. This method may
   // be called multiple times or not at all if an error occurs.
   virtual void OnReceivedData(std::unique_ptr<ReceivedData> data) = 0;
 
+  // Called when the transfer size is updated. This method may be called
+  // multiple times or not at all. The transfer size is the length of the
+  // response (including both headers and the body) over the network.
+  // |transfer_size_diff| is the difference from the value previously reported
+  // one (including the one in OnReceivedResponse). It must be positive.
+  virtual void OnTransferSizeUpdated(int transfer_size_diff) = 0;

[kinuko, 2016/12/07 04:06:26]

Should transfer_size_diff be unsigned if it must always be positive?

[yhirano, 2016/12/07 12:06:58]

Google c++ style guide says 

"
You should not use the unsigned integer types such as uint32_t, unless there is
a valid reason such as representing a bit pattern rather than a number, or you
need defined overflow modulo 2^N. In particular, do not use unsigned types to
say a number will never be negative. Instead, use assertions for this.
"

https://google.github.io/styleguide/cppguide.html#Integer_Types

+
   // Called when metadata generated by the renderer is retrieved from the
   // cache. This method may be called zero or one times.
   virtual void OnReceivedCachedMetadata(const char* data, int len) {}
 
   // Called when the response is complete.  This method signals completion of
   // the resource load.
   virtual void OnCompletedRequest(int error_code,
                                   bool was_ignored_by_handler,
                                   bool stale_copy_in_cache,
                                   const base::TimeTicks& completion_time,
                                   int64_t total_transfer_size,
                                   int64_t encoded_body_size) = 0;
 
   virtual ~RequestPeer() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_CHILD_REQUEST_PEER_H_