Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Side by Side Diff: chrome/renderer/extensions/extension_localization_peer_unittest.cc

Issue 2540023003: Dispatch encoded_data_length separately in content/child (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/extension_localization_peer.h" 5 #include "chrome/renderer/extensions/extension_localization_peer.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <map> 9 #include <map>
10 #include <memory> 10 #include <memory>
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 65
66 MOCK_METHOD2(OnUploadProgress, void(uint64_t position, uint64_t size)); 66 MOCK_METHOD2(OnUploadProgress, void(uint64_t position, uint64_t size));
67 MOCK_METHOD2(OnReceivedRedirect, 67 MOCK_METHOD2(OnReceivedRedirect,
68 bool(const net::RedirectInfo& redirect_info, 68 bool(const net::RedirectInfo& redirect_info,
69 const content::ResourceResponseInfo& info)); 69 const content::ResourceResponseInfo& info));
70 MOCK_METHOD1(OnReceivedResponse, 70 MOCK_METHOD1(OnReceivedResponse,
71 void(const content::ResourceResponseInfo& info)); 71 void(const content::ResourceResponseInfo& info));
72 MOCK_METHOD2(OnDownloadedData, void(int len, int encoded_data_length)); 72 MOCK_METHOD2(OnDownloadedData, void(int len, int encoded_data_length));
73 void OnReceivedData( 73 void OnReceivedData(
74 std::unique_ptr<RequestPeer::ReceivedData> data) override { 74 std::unique_ptr<RequestPeer::ReceivedData> data) override {
75 OnReceivedDataInternal(data->payload(), data->length(), 75 OnReceivedDataInternal(data->payload(), data->length());
76 data->encoded_data_length());
77 } 76 }
78 MOCK_METHOD3(OnReceivedDataInternal, 77 MOCK_METHOD2(OnReceivedDataInternal, void(const char* data, int data_length));
79 void(const char* data, 78 MOCK_METHOD1(OnTransferSizeUpdated, void(int transfer_size_diff));
80 int data_length,
81 int encoded_data_length));
82 MOCK_METHOD6(OnCompletedRequest, 79 MOCK_METHOD6(OnCompletedRequest,
83 void(int error_code, 80 void(int error_code,
84 bool was_ignored_by_handler, 81 bool was_ignored_by_handler,
85 bool stale_copy_in_cache, 82 bool stale_copy_in_cache,
86 const base::TimeTicks& completion_time, 83 const base::TimeTicks& completion_time,
87 int64_t total_transfer_size, 84 int64_t total_transfer_size,
88 int64_t encoded_body_size)); 85 int64_t encoded_body_size));
89 86
90 private: 87 private:
91 DISALLOW_COPY_AND_ASSIGN(MockRequestPeer); 88 DISALLOW_COPY_AND_ASSIGN(MockRequestPeer);
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1)); 129 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
133 EXPECT_TRUE(NULL != filter_peer_.get()); 130 EXPECT_TRUE(NULL != filter_peer_.get());
134 } 131 }
135 132
136 TEST_F(ExtensionLocalizationPeerTest, OnReceivedData) { 133 TEST_F(ExtensionLocalizationPeerTest, OnReceivedData) {
137 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1)); 134 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
138 EXPECT_TRUE(GetData().empty()); 135 EXPECT_TRUE(GetData().empty());
139 136
140 const std::string data_chunk("12345"); 137 const std::string data_chunk("12345");
141 filter_peer_->OnReceivedData(base::MakeUnique<content::FixedReceivedData>( 138 filter_peer_->OnReceivedData(base::MakeUnique<content::FixedReceivedData>(
142 data_chunk.data(), data_chunk.length(), -1)); 139 data_chunk.data(), data_chunk.length()));
143 140
144 EXPECT_EQ(data_chunk, GetData()); 141 EXPECT_EQ(data_chunk, GetData());
145 142
146 filter_peer_->OnReceivedData(base::MakeUnique<content::FixedReceivedData>( 143 filter_peer_->OnReceivedData(base::MakeUnique<content::FixedReceivedData>(
147 data_chunk.data(), data_chunk.length(), -1)); 144 data_chunk.data(), data_chunk.length()));
148 EXPECT_EQ(data_chunk + data_chunk, GetData()); 145 EXPECT_EQ(data_chunk + data_chunk, GetData());
149 } 146 }
150 147
151 MATCHER_P(IsURLRequestEqual, status, "") { return arg.status() == status; } 148 MATCHER_P(IsURLRequestEqual, status, "") { return arg.status() == status; }
152 149
153 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestBadURLRequestStatus) { 150 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestBadURLRequestStatus) {
154 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1)); 151 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
155 152
156 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)); 153 EXPECT_CALL(*original_peer_, OnReceivedResponse(_));
157 EXPECT_CALL(*original_peer_, 154 EXPECT_CALL(*original_peer_,
158 OnCompletedRequest(net::ERR_ABORTED, false, false, 155 OnCompletedRequest(net::ERR_ABORTED, false, false,
159 base::TimeTicks(), -1, 0)); 156 base::TimeTicks(), -1, 0));
160 157
161 filter_peer_->OnCompletedRequest(net::ERR_FAILED, false, false, 158 filter_peer_->OnCompletedRequest(net::ERR_FAILED, false, false,
162 base::TimeTicks(), -1, 0); 159 base::TimeTicks(), -1, 0);
163 } 160 }
164 161
165 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestEmptyData) { 162 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestEmptyData) {
166 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1)); 163 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
167 164
168 EXPECT_CALL(*original_peer_, OnReceivedDataInternal(_, _, _)).Times(0); 165 EXPECT_CALL(*original_peer_, OnReceivedDataInternal(_, _)).Times(0);
169 EXPECT_CALL(*sender_, Send(_)).Times(0); 166 EXPECT_CALL(*sender_, Send(_)).Times(0);
170 167
171 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)); 168 EXPECT_CALL(*original_peer_, OnReceivedResponse(_));
172 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false, 169 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false,
173 base::TimeTicks(), -1, 0)); 170 base::TimeTicks(), -1, 0));
174 171
175 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1, 172 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1,
176 0); 173 0);
177 } 174 }
178 175
179 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestNoCatalogs) { 176 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestNoCatalogs) {
180 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1)); 177 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
181 178
182 SetData("some text"); 179 SetData("some text");
183 180
184 EXPECT_CALL(*sender_, Send(_)); 181 EXPECT_CALL(*sender_, Send(_));
185 182
186 std::string data = GetData(); 183 std::string data = GetData();
187 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)).Times(1); 184 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)).Times(1);
188 EXPECT_CALL(*original_peer_, 185 EXPECT_CALL(*original_peer_,
189 OnReceivedDataInternal(StrEq(data.c_str()), data.length(), -1)) 186 OnReceivedDataInternal(StrEq(data.c_str()), data.length()))
190 .Times(1); 187 .Times(1);
191 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false, 188 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false,
192 base::TimeTicks(), -1, -1)) 189 base::TimeTicks(), -1, -1))
193 .Times(1); 190 .Times(1);
194 191
195 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1, 192 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1,
196 -1); 193 -1);
197 194
198 // Test if Send gets called again (it shouldn't be) when first call returned 195 // Test if Send gets called again (it shouldn't be) when first call returned
199 // an empty dictionary. 196 // an empty dictionary.
200 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1)); 197 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
201 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)).Times(1); 198 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)).Times(1);
202 EXPECT_CALL(*original_peer_, 199 EXPECT_CALL(*original_peer_,
203 OnReceivedDataInternal(StrEq(data.c_str()), data.length(), -1)) 200 OnReceivedDataInternal(StrEq(data.c_str()), data.length()))
204 .Times(1); 201 .Times(1);
205 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false, 202 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false,
206 base::TimeTicks(), -1, -1)) 203 base::TimeTicks(), -1, -1))
207 .Times(1); 204 .Times(1);
208 SetData("some text"); 205 SetData("some text");
209 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1, 206 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1,
210 -1); 207 -1);
211 } 208 }
212 209
213 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestWithCatalogs) { 210 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestWithCatalogs) {
214 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_2)); 211 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_2));
215 212
216 extensions::L10nMessagesMap messages; 213 extensions::L10nMessagesMap messages;
217 messages.insert(std::make_pair("text", "new text")); 214 messages.insert(std::make_pair("text", "new text"));
218 extensions::ExtensionToL10nMessagesMap& l10n_messages_map = 215 extensions::ExtensionToL10nMessagesMap& l10n_messages_map =
219 *extensions::GetExtensionToL10nMessagesMap(); 216 *extensions::GetExtensionToL10nMessagesMap();
220 l10n_messages_map["some_id2"] = messages; 217 l10n_messages_map["some_id2"] = messages;
221 218
222 SetData("some __MSG_text__"); 219 SetData("some __MSG_text__");
223 220
224 // We already have messages in memory, Send will be skipped. 221 // We already have messages in memory, Send will be skipped.
225 EXPECT_CALL(*sender_, Send(_)).Times(0); 222 EXPECT_CALL(*sender_, Send(_)).Times(0);
226 223
227 // __MSG_text__ gets replaced with "new text". 224 // __MSG_text__ gets replaced with "new text".
228 std::string data("some new text"); 225 std::string data("some new text");
229 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)); 226 EXPECT_CALL(*original_peer_, OnReceivedResponse(_));
230 EXPECT_CALL(*original_peer_, 227 EXPECT_CALL(*original_peer_,
231 OnReceivedDataInternal(StrEq(data.c_str()), data.length(), -1)); 228 OnReceivedDataInternal(StrEq(data.c_str()), data.length()));
232 229
233 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false, 230 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false,
234 base::TimeTicks(), -1, -1)); 231 base::TimeTicks(), -1, -1));
235 232
236 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1, 233 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1,
237 -1); 234 -1);
238 } 235 }
239 236
240 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestReplaceMessagesFails) { 237 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestReplaceMessagesFails) {
241 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_3)); 238 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_3));
242 239
243 extensions::L10nMessagesMap messages; 240 extensions::L10nMessagesMap messages;
244 messages.insert(std::make_pair("text", "new text")); 241 messages.insert(std::make_pair("text", "new text"));
245 extensions::ExtensionToL10nMessagesMap& l10n_messages_map = 242 extensions::ExtensionToL10nMessagesMap& l10n_messages_map =
246 *extensions::GetExtensionToL10nMessagesMap(); 243 *extensions::GetExtensionToL10nMessagesMap();
247 l10n_messages_map["some_id3"] = messages; 244 l10n_messages_map["some_id3"] = messages;
248 245
249 std::string message("some __MSG_missing_message__"); 246 std::string message("some __MSG_missing_message__");
250 SetData(message); 247 SetData(message);
251 248
252 // We already have messages in memory, Send will be skipped. 249 // We already have messages in memory, Send will be skipped.
253 EXPECT_CALL(*sender_, Send(_)).Times(0); 250 EXPECT_CALL(*sender_, Send(_)).Times(0);
254 251
255 // __MSG_missing_message__ is missing, so message stays the same. 252 // __MSG_missing_message__ is missing, so message stays the same.
256 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)); 253 EXPECT_CALL(*original_peer_, OnReceivedResponse(_));
257 EXPECT_CALL(*original_peer_, OnReceivedDataInternal(StrEq(message.c_str()), 254 EXPECT_CALL(*original_peer_,
258 message.length(), -1)); 255 OnReceivedDataInternal(StrEq(message.c_str()), message.length()));
259 256
260 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false, 257 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false,
261 base::TimeTicks(), -1, 0)); 258 base::TimeTicks(), -1, 0));
262 259
263 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1, 260 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1,
264 0); 261 0);
265 } 262 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698