Chromium Code Reviews| Index: chrome/browser/ui/webui/settings/about_handler.cc |
| diff --git a/chrome/browser/ui/webui/settings/about_handler.cc b/chrome/browser/ui/webui/settings/about_handler.cc |
| index 833edb252fca5f597f8b25db450850c38d544f10..65f12f4cbe51f0e5a23e94e19ceb9e97e2c3fd11 100644 |
| --- a/chrome/browser/ui/webui/settings/about_handler.cc |
| +++ b/chrome/browser/ui/webui/settings/about_handler.cc |
| @@ -263,8 +263,18 @@ AboutHandler* AboutHandler::Create(content::WebUIDataSource* html_source, |
| Profile* profile) { |
| html_source->AddString( |
| "aboutBrowserVersion", |
| - l10n_util::GetStringFUTF16(IDS_ABOUT_PRODUCT_VERSION, |
| - BuildBrowserVersionString())); |
| + l10n_util::GetStringFUTF16( |
| + IDS_SETTINGS_ABOUT_PAGE_BROWSER_VERSION, |
| + base::UTF8ToUTF16(version_info::GetVersionNumber()), |
| + l10n_util::GetStringUTF16(version_info::IsOfficialBuild() |
| + ? IDS_VERSION_UI_OFFICIAL |
| + : IDS_VERSION_UI_UNOFFICIAL), |
| + base::UTF8ToUTF16(chrome::GetChannelString()), |
| +#if defined(ARCH_CPU_64_BITS) |
| + l10n_util::GetStringUTF16(IDS_VERSION_UI_64BIT))); |
| +#else |
| + l10n_util::GetStringUTF16(IDS_VERSION_UI_32BIT))); |
| +#endif |
| html_source->AddString( |
| "aboutProductCopyright", |
| @@ -396,21 +406,6 @@ void AboutHandler::Observe(int type, |
| RequestUpdate(); |
| } |
| -// static |
| -base::string16 AboutHandler::BuildBrowserVersionString() { |
| - std::string version = version_info::GetVersionNumber(); |
| - |
| - std::string modifier = chrome::GetChannelString(); |
| - if (!modifier.empty()) |
| - version += " " + modifier; |
| - |
| -#if defined(ARCH_CPU_64_BITS) |
| - version += " (64-bit)"; |
|
Dan Beam
2016/12/03 01:26:07
ahhhh, this wasn't using IDS_VERSION_UI_{32,64}BIT
dpapad
2016/12/03 02:08:30
Acknowledged.
|
| -#endif |
| - |
| - return base::UTF8ToUTF16(version); |
| -} |
| - |
| void AboutHandler::OnDeviceAutoUpdatePolicyChanged( |
| const base::Value* previous_policy, |
| const base::Value* current_policy) { |