Fix cmd-up/cmd-down.

webkit/glue/webframe_impl.cc

 /*
  * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 103 matching lines @@
 #endif
 #include "RenderView.h"
 #include "RenderWidget.h"
 #include "ReplaceSelectionCommand.h"
 #include "ResourceHandle.h"
 #include "ResourceRequest.h"
 #include "ScriptController.h"
 #include "ScriptSourceCode.h"
 #include "ScriptValue.h"
 #include "ScrollbarTheme.h"
+#include "ScrollTypes.h"
 #include "SelectionController.h"
 #include "Settings.h"
 #include "SkiaUtils.h"
 #include "SubstituteData.h"
 #include "TextIterator.h"
 #include "TextAffinity.h"
 #include "XPathResult.h"
 
 MSVC_POP_WARNING();
 
@@ skipping 870 matching lines @@
     frame()->editor()->showSpellingGuessPanel();
   } else {
     rv = frame()->editor()->command(AtomicString(command.c_str())).execute();
   }
   return rv;
 }
 
 bool WebFrameImpl::executeCommand(const WebString& name,
                                   const WebString& value) {
   ASSERT(frame());
-  return frame()->editor()->command(webkit_glue::WebStringToString(name)).
-      execute(webkit_glue::WebStringToString(value));
+  WebCore::String web_name = webkit_glue::WebStringToString(name);
+
+  // moveToBeginningOfDocument and moveToEndfDocument are only handled by WebKit
+  // for editable nodes.

[jeremy, 2009/09/29 18:12:56]

hbono had quite alot to say about this, could you elaborate on this comment if
there's anything more to say here?

[Nico, 2009/09/30 03:51:35]

Not sure what you're after…he suggested that we should disable edit commands for
non-editable nodes in general, but that breaks e.g. selectAll as noted on the
bug, so I came up with this approach. Do you want me to add something to the
comment (what?) or…?

+  if (!frame()->editor()->canEdit() &&
+      web_name == "moveToBeginningOfDocument") {
+    return GetWebViewImpl()->PropagateScroll(WebCore::ScrollUp,
+                                             WebCore::ScrollByDocument);
+  } else if (!frame()->editor()->canEdit() &&
+      web_name == "moveToEndOfDocument") {
+    return GetWebViewImpl()->PropagateScroll(WebCore::ScrollDown,
+                                             WebCore::ScrollByDocument);
+  } else {
+    return frame()->editor()->command(web_name).
+        execute(webkit_glue::WebStringToString(value));
+  }
 }
 
 bool WebFrameImpl::isCommandEnabled(const WebString& name) const {
   ASSERT(frame());
   return frame()->editor()->command(webkit_glue::WebStringToString(name)).
       isEnabled();
 }
 
 void WebFrameImpl::enableContinuousSpellChecking(bool enable) {
   if (enable == isContinuousSpellCheckingEnabled())
@@ skipping 873 matching lines @@
 
   SecurityOrigin* security_origin = frame_->document()->securityOrigin();
 
   if (!frame_->loader()->isScheduledLocationChangePending()) {
     frame_->loader()->stopAllLoaders();
     frame_->loader()->begin(frame_->loader()->url(), true, security_origin);
     frame_->loader()->write(script_result);
     frame_->loader()->end();
   }
 }