Fix cmd-up/cmd-down.

chrome/renderer/render_view.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/render_view.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 1494 matching lines @@
   if (edit_commands_.empty())
     return false;
 
   WebFrame* frame = webview()->GetFocusedFrame();
   if (!frame)
     return false;
 
   EditCommands::iterator it = edit_commands_.begin();
   EditCommands::iterator end = edit_commands_.end();
 
+  bool did_execute_command = false;
   for (; it != end; ++it) {
+    // In gtk, it's possible to bind multiple edit commands to one key (but it's
+    // the exception). Once one edit command is not executed, it seems safest to
+    // not execute the rest.

[jeremy, 2009/09/29 18:12:56]

Are we sure this isn't possible on OSX as well?
According to http://www.erasetotheleft.com/post/mac-os-x-key-bindings/ you can
bind a key to multiple edit commands on OS X.

[Nico, 2009/09/30 03:51:35]

Oh, this wasn't supposed to mean "only in gtk" but "for example in gtk". I guess
being explicit doesn't hurt. Done.

     if (!frame->executeCommand(WebString::fromUTF8(it->name),
                                WebString::fromUTF8(it->value)))
       break;
+    did_execute_command = true;
   }
 
-  return true;
+  return did_execute_command;
 }
 
 void RenderView::spellCheck(
     const WebString& text, int& misspelled_offset, int& misspelled_length) {
   EnsureDocumentTag();
   Send(new ViewHostMsg_SpellCheck(
       routing_id_, UTF16ToWideHack(text), document_tag_,
       &misspelled_offset, &misspelled_length));
 }
 
@@ skipping 2039 matching lines @@
     modal_dialog_event_->Signal();
 
   message->EnableMessagePumping();  // Runs a nested message loop.
   bool rv = Send(message);
 
   if (--modal_dialog_count_ == 0)
     modal_dialog_event_->Reset();
 
   return rv;
 }