Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 2540013006: Reland of win: Remove unneeded references to visual_studio_version now that it's always 2015. (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
Reviewers:
Nico, scottmg, brucedawson
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of win: Remove unneeded references to visual_studio_version now that it's always 2015. (patchset #2 id:150001 of https://codereview.chromium.org/2531333004/ ) Reason for revert: V8 is on 2015 now. Original issue's description: > Revert of win: Remove unneeded references to visual_studio_version now that it's always 2015. (patchset #4 id:60001 of https://codereview.chromium.org/2450933002/ ) > > Reason for revert: > V8 relies on this. > > Original issue's description: > > win: Remove unneeded references to visual_studio_version now that it's always 2015. > > > > BUG= > > > > Committed: https://crrev.com/a628db5056deb88589224bd68dcd9ec029932c83 > > Cr-Commit-Position: refs/heads/master@{#427463} > > TBR=scottmg@chromium.org,thakis@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= > > Committed: https://crrev.com/f89b499961b139f38e8e01282a82d4ba5d21506e > Cr-Commit-Position: refs/heads/master@{#434945} TBR=scottmg@chromium.org,thakis@chromium.org,brucedawson@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603131 Committed: https://crrev.com/fd2c63b1b790d0c41a41b708271e3d0264cbdbee Cr-Commit-Position: refs/heads/master@{#435944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -107 lines) Patch
M base/BUILD.gn View 2 chunks +48 lines, -60 lines 0 comments Download
M build/config/compiler/BUILD.gn View 4 chunks +13 lines, -19 lines 0 comments Download
M build/config/win/BUILD.gn View 1 chunk +14 lines, -26 lines 0 comments Download
M build/config/win/visual_studio_version.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/mini_installer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Michael Achenbach
Created Reland of win: Remove unneeded references to visual_studio_version now that it's always 2015.
4 years ago (2016-12-02 14:55:56 UTC) #1
Michael Achenbach
PTAL
4 years ago (2016-12-02 14:56:25 UTC) #3
Nico
lgtm, thanks for following up :-)
4 years ago (2016-12-02 14:57:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540013006/1
4 years ago (2016-12-02 15:02:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 15:59:08 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fd2c63b1b790d0c41a41b708271e3d0264cbdbee Cr-Commit-Position: refs/heads/master@{#435944}
4 years ago (2016-12-02 16:00:50 UTC) #14
brucedawson
4 years ago (2016-12-05 01:09:56 UTC) #15
Message was sent while issue was closed.
Nice, lgtm.

Powered by Google App Engine
This is Rietveld 408576698