Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2540013005: Reland of Reenable Tabdragging tests failing because of IsWindowPositionManaged() (Closed)

Created:
4 years ago by afakhry
Modified:
4 years ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Reenable Tabdragging tests failing because of IsWindowPositionManaged() It was reverted previously as it caused a crash in WorkspaceEventHandlerTest.DeleteWhileInRunLoop. It used to be exiting the move loop and clearing the move_loop_widget_ before EndDrag() had a chance to set the window position to manageable again. This CL adds a maximized browser window waiter, and moves setting the window position managed logic to ash. TBR=pkasting@chromium.org,sky@chromium.org,skuhne@chromium.org,oshima@chromium.org,erg@chromium.org BUG=626761, 331924 TEST=interactive_ui_tests --gtest_filter=TabDragging* Committed: https://crrev.com/83e8abcce5801546b4bb2ff03fdaf5cb4590f0e5 Cr-Commit-Position: refs/heads/master@{#435775}

Patch Set 1 : Original CL #

Patch Set 2 : Applying the fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -49 lines) Patch
M ash/wm/toplevel_window_event_handler.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 chunk +61 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 9 chunks +1 line, -34 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 8 chunks +59 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540013005/40001
4 years ago (2016-12-01 23:09:43 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-01 23:55:22 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-01 23:58:06 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83e8abcce5801546b4bb2ff03fdaf5cb4590f0e5
Cr-Commit-Position: refs/heads/master@{#435775}

Powered by Google App Engine
This is Rietveld 408576698