Enable sRGB on iOS, make sRGB decode support optional

Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

Adjust the test code to produce sRGB capable contexts on these devices,
but only for configs that have a color space. (See comment).

BUG=skia:4148
Committed: https://skia.googlesource.com/skia/+/9db12d2341f3f8722c8b90b11dd4cce138a8a64e
Committed: https://skia.googlesource.com/skia/+/1aeb78c5d978b35b256525b711edd942bce01444
Committed: https://skia.googlesource.com/skia/+/20471894eaa441193d5ae8f2395e8244c91c55af

[Brian Osman, 2016-11-30 15:05:59]

Description was changed from

==========
Enable sRGB on PowerVR

BUG=skia:
==========

to

==========
Some clients have no interest in mixed legacy/color-correct rendering, and
want to use sRGB on a wider range of devices (that support sRGB, but not
the decode extension). Setting this flag on GrContextOptions enables sRGB
support on those devices.

BUG=skia:4148
==========

[Brian Osman, 2016-11-30 16:51:56]

Description was changed from

==========
Some clients have no interest in mixed legacy/color-correct rendering, and
want to use sRGB on a wider range of devices (that support sRGB, but not
the decode extension). Setting this flag on GrContextOptions enables sRGB
support on those devices.

BUG=skia:4148
==========

to

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

BUG=skia:4148
==========

[Brian Osman, 2016-11-30 16:53:12]

brianosman@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2016-11-30 17:00:22]

I know "SRGBDecodeSupport" comes from the GL language but I find it confusing
because what we really mean is the capability to disable SRGB decoding. Maybe
something like treatSRGBTextureAsLinearSupport(), srgbDecodeDisableSupport(), ..

https://codereview.chromium.org/2539993002/diff/100001/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/2539993002/diff/100001/src/gpu/gl/GrGLCaps.cp...
src/gpu/gl/GrGLCaps.cpp:1590: if (fRequireDecodeForSRGB && !fSRGBDecodeSupport)
{
Should we just pass the options here rather than having this fRequire member?

https://codereview.chromium.org/2539993002/diff/100001/tests/SRGBMipMapTest.cpp
File tests/SRGBMipMapTest.cpp (right):

https://codereview.chromium.org/2539993002/diff/100001/tests/SRGBMipMapTest.c...
tests/SRGBMipMapTest.cpp:151: if (glGpu->glCaps().srgbDecodeSupport()) {
Should we have this on GrCaps rather than GrGLCaps?

[Brian Osman, 2016-11-30 19:28:33]

Description was changed from

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

BUG=skia:4148
==========

to

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

Adjust the test code to produce sRGB capable contexts on these devices,
but only for configs that have a color space. (See comment).

BUG=skia:4148
==========

[Brian Osman, 2016-11-30 19:31:30]

Fixed some issues, modified testing logic so we'll get sRGB testing on any
device that supports it (even without the decode extension). Put in more/bigger
comments to try and explain the reasoning everywhere.

From my local check, one GM produces incorrect results on devices in this bucket
(but it's exercising unsupported behavior for that option), one GM has
single-bit fluctuation, and one GM changes behavior in sRGB mode (relative to a
device that has decode support).

[Brian Osman, 2016-11-30 19:32:11]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 19:32:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-11-30 20:00:32]

The CQ bit was unchecked by brianosman@google.com

[bsalomon, 2016-11-30 22:19:42]

lgtm

[Brian Osman, 2016-12-01 16:20:57]

Okay, fixing the logic to blacklist NexusPlayer - that device is still failing
the test, even with everything forced to highp.

[Brian Osman, 2016-12-01 16:21:07]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 16:21:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 17:00:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 17:00:29]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-12-01 17:00:52]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-12-01 17:00:53]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2539993002/#ps200001
(title: "Blacklist NexusPlayer (x86 PowerVR)")

[commit-bot: I haz the power, 2016-12-01 17:00:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsalomon, 2016-12-01 17:01:20]

lgtm

[commit-bot: I haz the power, 2016-12-01 17:02:04]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1480611652735920,
"parent_rev": "9afd371a8a66f992f98eb2a3fc75ae64bddc730b", "commit_rev":
"9db12d2341f3f8722c8b90b11dd4cce138a8a64e"}

[commit-bot: I haz the power, 2016-12-01 17:02:06]

Description was changed from

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

Adjust the test code to produce sRGB capable contexts on these devices,
but only for configs that have a color space. (See comment).

BUG=skia:4148
==========

to

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

Adjust the test code to produce sRGB capable contexts on these devices,
but only for configs that have a color space. (See comment).

BUG=skia:4148

Committed:
https://skia.googlesource.com/skia/+/9db12d2341f3f8722c8b90b11dd4cce138a8a64e
==========

[commit-bot: I haz the power, 2016-12-01 17:02:08]

Committed patchset #11 (id:200001) as
https://skia.googlesource.com/skia/+/9db12d2341f3f8722c8b90b11dd4cce138a8a64e

[Brian Osman, 2016-12-01 18:41:47]

A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.chromium.org/2547603002/ by brianosman@google.com.

The reason for reverting is: ANGLE tests are failing.

[Brian Osman, 2016-12-01 20:23:23]

Description was changed from

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

Adjust the test code to produce sRGB capable contexts on these devices,
but only for configs that have a color space. (See comment).

BUG=skia:4148

Committed:
https://skia.googlesource.com/skia/+/9db12d2341f3f8722c8b90b11dd4cce138a8a64e
==========

to

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

Adjust the test code to produce sRGB capable contexts on these devices,
but only for configs that have a color space. (See comment).

BUG=skia:4148

Committed:
https://skia.googlesource.com/skia/+/9db12d2341f3f8722c8b90b11dd4cce138a8a64e
==========

[Brian Osman, 2016-12-01 20:24:16]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 20:24:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-12-01 20:51:33]

PS12 re-disables sRGB on ES/BGRA

[bsalomon, 2016-12-01 20:53:53]

lgtm

[commit-bot: I haz the power, 2016-12-01 21:10:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:10:31]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-12-01 21:17:12]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-12-01 21:17:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 21:18:16]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1480627032916490,
"parent_rev": "f6878baba8c7cd347e185361bac2eabaef863bfa", "commit_rev":
"1aeb78c5d978b35b256525b711edd942bce01444"}

[commit-bot: I haz the power, 2016-12-01 21:18:19]

Description was changed from

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

Adjust the test code to produce sRGB capable contexts on these devices,
but only for configs that have a color space. (See comment).

BUG=skia:4148

Committed:
https://skia.googlesource.com/skia/+/9db12d2341f3f8722c8b90b11dd4cce138a8a64e
==========

to

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

Adjust the test code to produce sRGB capable contexts on these devices,
but only for configs that have a color space. (See comment).

BUG=skia:4148

Committed:
https://skia.googlesource.com/skia/+/9db12d2341f3f8722c8b90b11dd4cce138a8a64e
Committed:
https://skia.googlesource.com/skia/+/1aeb78c5d978b35b256525b711edd942bce01444
==========

[commit-bot: I haz the power, 2016-12-01 21:18:20]

Committed patchset #12 (id:220001) as
https://skia.googlesource.com/skia/+/1aeb78c5d978b35b256525b711edd942bce01444

[Brian Osman, 2016-12-01 21:59:15]

A revert of this CL (patchset #12 id:220001) has been created in
https://codereview.chromium.org/2546783005/ by brianosman@google.com.

The reason for reverting is: Command Buffer, too....

[Brian Osman, 2016-12-02 14:32:50]

Description was changed from

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

Adjust the test code to produce sRGB capable contexts on these devices,
but only for configs that have a color space. (See comment).

BUG=skia:4148

Committed:
https://skia.googlesource.com/skia/+/9db12d2341f3f8722c8b90b11dd4cce138a8a64e
Committed:
https://skia.googlesource.com/skia/+/1aeb78c5d978b35b256525b711edd942bce01444
==========

to

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

Adjust the test code to produce sRGB capable contexts on these devices,
but only for configs that have a color space. (See comment).

BUG=skia:4148

Committed:
https://skia.googlesource.com/skia/+/9db12d2341f3f8722c8b90b11dd4cce138a8a64e
Committed:
https://skia.googlesource.com/skia/+/1aeb78c5d978b35b256525b711edd942bce01444
==========

[Brian Osman, 2016-12-02 14:33:03]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-12-02 14:33:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 14:43:33]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1480689183233190,
"parent_rev": "4b7b6f0229fa51f5beb71f92cb77ba84d39b41e1", "commit_rev":
"20471894eaa441193d5ae8f2395e8244c91c55af"}

[commit-bot: I haz the power, 2016-12-02 14:43:35]

Description was changed from

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

Adjust the test code to produce sRGB capable contexts on these devices,
but only for configs that have a color space. (See comment).

BUG=skia:4148

Committed:
https://skia.googlesource.com/skia/+/9db12d2341f3f8722c8b90b11dd4cce138a8a64e
Committed:
https://skia.googlesource.com/skia/+/1aeb78c5d978b35b256525b711edd942bce01444
==========

to

==========
Two (related) changes here:

1) Our older iOS devices failed our sRGB tests, due to precision issues
with alpha. At this point, we only test on iPadMini 4, and that appears
not to have any problems.

2) iOS devices still don't have the sRGB texture decode extension. But,
some clients have no interest in mixing legacy/color-correct rendering,
and would like to use sRGB on these devices. This GrContextOptions flag
enables sRGB support in those cases.

Adjust the test code to produce sRGB capable contexts on these devices,
but only for configs that have a color space. (See comment).

BUG=skia:4148

Committed:
https://skia.googlesource.com/skia/+/9db12d2341f3f8722c8b90b11dd4cce138a8a64e
Committed:
https://skia.googlesource.com/skia/+/1aeb78c5d978b35b256525b711edd942bce01444
Committed:
https://skia.googlesource.com/skia/+/20471894eaa441193d5ae8f2395e8244c91c55af
==========

[commit-bot: I haz the power, 2016-12-02 14:43:37]

Committed patchset #12 (id:220001) as
https://skia.googlesource.com/skia/+/20471894eaa441193d5ae8f2395e8244c91c55af