Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 2539973003: use SkClipOps instead of SkRegion::Op for canvas clipping (Closed)

Created:
4 years ago by reed1
Modified:
4 years ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, bruthig+ink_drop_chromium.org, Rik, cc-bugs_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dcheng, devtools-reviews_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, extensions-reviews_chromium.org, f(malita), groby+bubble_chromium.org, hcarmona+bubble_chromium.org, jam, jbauman+watch_chromium.org, jbroman, Justin Novosad, kalyank, mlamouri+watch-content_chromium.org, msw+watch_chromium.org, pdr+graphicswatchlist_chromium.org, pfeldman, piman+watch_chromium.org, rwlbuis, rouslan+bubble_chromium.org, sadrul, Stephen Chennney, tfarina, Ian Vollick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

use SkClipOps instead of SkRegion::Op for canvas clipping This allows us to restrict the verbs for canvas clipping to just those that contract the clip. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR= Committed: https://crrev.com/e9559d0c2c6dd8408d408b795c86f3ff7dfc178e Cr-Commit-Position: refs/heads/master@{#436422}

Patch Set 1 #

Patch Set 2 : fix more sites #

Total comments: 10

Patch Set 3 : address nits #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -161 lines) Patch
M ash/common/system/tray/tray_details_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/blink/web_display_item_list_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/blink/web_display_item_list_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/output/software_renderer.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M cc/playback/clip_display_item.cc View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
M cc/playback/clip_path_display_item.h View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/playback/clip_path_display_item.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/playback/display_item_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/playback/raster_source.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/proto/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M cc/proto/display_item.proto View 2 chunks +2 lines, -2 lines 0 comments Download
A cc/proto/skclipop.proto View 1 chunk +20 lines, -0 lines 0 comments Download
M cc/proto/skia_conversions.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M cc/proto/skia_conversions.cc View 2 chunks +29 lines, -28 lines 0 comments Download
M cc/proto/skia_conversions_unittest.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/windows_10_caption_button.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/color_picker.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/skia_benchmarking_extension_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M skia/ext/analysis_canvas.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M skia/ext/analysis_canvas.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M skia/ext/benchmarking_canvas.h View 1 chunk +4 lines, -4 lines 0 comments Download
M skia/ext/benchmarking_canvas.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/ClipList.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 2 5 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/InterceptingCanvas.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/LoggingCanvas.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp View 1 2 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebDisplayItemList.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M ui/compositor/clip_recorder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/animation/ink_drop_painted_layer_delegates.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/bubble/bubble_border.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 41 (28 generated)
reed1
4 years ago (2016-11-30 16:36:42 UTC) #3
f(malita)
LGTM https://codereview.chromium.org/2539973003/diff/20001/cc/playback/clip_display_item.cc File cc/playback/clip_display_item.cc (right): https://codereview.chromium.org/2539973003/diff/20001/cc/playback/clip_display_item.cc#newcode69 cc/playback/clip_display_item.cc:69: antialias_); uNit: clipRect(gfx::RectToSkRect(clip_rect_), antialias_) ? https://codereview.chromium.org/2539973003/diff/20001/cc/playback/clip_display_item.cc#newcode73 cc/playback/clip_display_item.cc:73: antialias_); ...
4 years ago (2016-12-02 15:22:58 UTC) #10
reed1
https://codereview.chromium.org/2539973003/diff/20001/cc/playback/clip_display_item.cc File cc/playback/clip_display_item.cc (right): https://codereview.chromium.org/2539973003/diff/20001/cc/playback/clip_display_item.cc#newcode69 cc/playback/clip_display_item.cc:69: antialias_); On 2016/12/02 15:22:58, f(malita) wrote: > uNit: clipRect(gfx::RectToSkRect(clip_rect_), ...
4 years ago (2016-12-02 20:50:30 UTC) #13
reed1
4 years ago (2016-12-02 20:52:31 UTC) #17
Peter Kasting
This CL is large and there are lots of reviewers. Please say what you want ...
4 years ago (2016-12-02 20:54:19 UTC) #18
esprehn
lgtm
4 years ago (2016-12-02 21:05:26 UTC) #19
sadrul
lgtm
4 years ago (2016-12-02 21:24:20 UTC) #20
dgozman
devtools lgtm
4 years ago (2016-12-02 21:25:35 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539973003/40001
4 years ago (2016-12-05 18:41:32 UTC) #31
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/public/platform/WebDisplayItemList.h: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-05 18:48:30 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539973003/60001
4 years ago (2016-12-05 19:52:05 UTC) #36
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-05 22:22:34 UTC) #39
commit-bot: I haz the power
4 years ago (2016-12-05 22:27:26 UTC) #41
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e9559d0c2c6dd8408d408b795c86f3ff7dfc178e
Cr-Commit-Position: refs/heads/master@{#436422}

Powered by Google App Engine
This is Rietveld 408576698