Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2539953002: Revert of Insert logcat as part of test result for android instrumentation tests. (Closed)

Created:
4 years ago by jbudorick
Modified:
4 years ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Insert logcat as part of test result for android instrumentation tests. (patchset #12 id:220001 of https://codereview.chromium.org/2451523002/ ) Reason for revert: breaking on chromium.android: https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/6567 Original issue's description: > Insert logcat as part of test result for android instrumentation tests. > > In this cl, we are trying to add the logcat of each instrumentation > test into the corresponding test result object, so that when we are > checking the result of each test case, we would be able to see the > corresponding logcat for that test case at the same time. > > BUG=631213 > > Committed: https://crrev.com/db14e1adbd87e01676f5915881571552e384a8d3 > Cr-Commit-Position: refs/heads/master@{#435041} TBR=mikecase@chromium.org,hzl@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631213 Committed: https://crrev.com/7f3d142161b15869f6bea58ac43c5f52ce5834ac Cr-Commit-Position: refs/heads/master@{#435078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -127 lines) Patch
D build/android/pylib/android/__init__.py View 1 chunk +0 lines, -4 lines 0 comments Download
D build/android/pylib/android/logdog_logcat_monitor.py View 1 chunk +0 lines, -83 lines 0 comments Download
M build/android/pylib/base/base_test_result.py View 2 chunks +0 lines, -7 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 3 chunks +0 lines, -10 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 3 chunks +3 lines, -14 lines 0 comments Download
M build/android/pylib/results/json_results.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/test_runner.pydeps View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jbudorick
Created Revert of Insert logcat as part of test result for android instrumentation tests.
4 years ago (2016-11-29 20:50:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539953002/1
4 years ago (2016-11-29 20:51:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 20:54:01 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-29 20:55:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f3d142161b15869f6bea58ac43c5f52ce5834ac
Cr-Commit-Position: refs/heads/master@{#435078}

Powered by Google App Engine
This is Rietveld 408576698