Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: net/socket/ssl_client_socket_unittest.cc

Issue 2539933002: Roll src/third_party/boringssl/src e1cc35e58..f086df9f5 (Closed)
Patch Set: Fix SCT test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | third_party/boringssl/BUILD.generated.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_unittest.cc
diff --git a/net/socket/ssl_client_socket_unittest.cc b/net/socket/ssl_client_socket_unittest.cc
index d451d31c2e95d794852f617e0379de425d9cc152..b80aa4ddf5af432f12e54a5e7a7012dea7cd1b0a 100644
--- a/net/socket/ssl_client_socket_unittest.cc
+++ b/net/socket/ssl_client_socket_unittest.cc
@@ -2298,9 +2298,11 @@ TEST_F(SSLClientSocketCertRequestInfoTest, CertKeyTypes) {
}
TEST_F(SSLClientSocketTest, ConnectSignedCertTimestampsEnabledTLSExtension) {
- SpawnedTestServer::SSLOptions ssl_options;
- ssl_options.signed_cert_timestamps_tls_ext = "test";
+ // Encoding of SCT List containing 'test'.
+ std::string sct_ext("\x00\x06\x00\x04test", 8);
+ SpawnedTestServer::SSLOptions ssl_options;
+ ssl_options.signed_cert_timestamps_tls_ext = sct_ext;
ASSERT_TRUE(StartTestServer(ssl_options));
SSLConfig ssl_config;
@@ -2310,8 +2312,8 @@ TEST_F(SSLClientSocketTest, ConnectSignedCertTimestampsEnabledTLSExtension) {
SetCTVerifier(&ct_verifier);
// Check that the SCT list is extracted as expected.
- EXPECT_CALL(ct_verifier, Verify(_, "", "test", _, _)).WillRepeatedly(
- Return(ERR_CT_NO_SCTS_VERIFIED_OK));
+ EXPECT_CALL(ct_verifier, Verify(_, "", sct_ext, _, _))
+ .WillRepeatedly(Return(ERR_CT_NO_SCTS_VERIFIED_OK));
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(ssl_config, &rv));
« no previous file with comments | « DEPS ('k') | third_party/boringssl/BUILD.generated.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698