Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2539913004: Revert of Disabled ink drop animations based on gfx::Animation::ShouldRenderRichAnimation(). (Closed)

Created:
4 years ago by bruthig
Modified:
4 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disabled ink drop animations based on gfx::Animation::ShouldRenderRichAnimation(). (patchset #4 id:60001 of https://codereview.chromium.org/2520353004/ ) Reason for revert: Failing tests on windows bots. I suspect the tests are actually dependent on environment settings which is not good and will require time to investigate. Original issue's description: > Disabled ink drop animations based on gfx::Animation::ShouldRenderRichAnimation(). > > Forces an animation duration of 0 for all ink drop animations if > ShouldRenderRichAnimations() returns false. > > BUG=658384 > > Committed: https://crrev.com/03ac98e06185f954738f1d3ec98c387b412c53f3 > Cr-Commit-Position: refs/heads/master@{#434301} TBR=pkasting@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=658384 Committed: https://crrev.com/cc642e808f2aa44bc748c5a528c16cd78c054030 Cr-Commit-Position: refs/heads/master@{#435276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M ui/views/animation/flood_fill_ink_drop_ripple.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/animation/ink_drop_highlight.cc View 4 chunks +2 lines, -8 lines 0 comments Download
M ui/views/animation/square_ink_drop_ripple.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bruthig
Created Revert of Disabled ink drop animations based on gfx::Animation::ShouldRenderRichAnimation().
4 years ago (2016-11-30 15:12:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539913004/1
4 years ago (2016-11-30 15:12:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 16:13:29 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-30 16:15:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc642e808f2aa44bc748c5a528c16cd78c054030
Cr-Commit-Position: refs/heads/master@{#435276}

Powered by Google App Engine
This is Rietveld 408576698