Mus: Implement GpuMain mojo interface

services/ui/ws/gpu_service_proxy.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/ui/ws/gpu_service_proxy.h"
 
 #include "base/memory/shared_memory.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/threading/thread_task_runner_handle.h"
@@ skipping 17 matching lines @@
 }  // namespace
 
 GpuServiceProxy::GpuServiceProxy(GpuServiceProxyDelegate* delegate)
     : delegate_(delegate),
       next_client_id_(kInternalGpuChannelClientId + 1),
       main_thread_task_runner_(base::ThreadTaskRunnerHandle::Get()) {
   gpu_main_.OnStart();
   // TODO(sad): Once GPU process is split, this would look like:
   //   connector->ConnectToInterface("gpu", &gpu_service_);
   gpu_main_.Create(GetProxy(&gpu_service_));
+  pending_display_compositor_factory_request_ =
+      GetProxy(&display_compositor_factory_);
   gpu_service_->Initialize(
       base::Bind(&GpuServiceProxy::OnInitialized, base::Unretained(this)));
   gpu_memory_buffer_manager_ = base::MakeUnique<MusGpuMemoryBufferManager>(
       gpu_service_.get(), next_client_id_++);
 }
 
 GpuServiceProxy::~GpuServiceProxy() {
 }
 
 void GpuServiceProxy::Add(mojom::GpuServiceRequest request) {
   bindings_.AddBinding(this, std::move(request));
 }
 
 void GpuServiceProxy::CreateDisplayCompositor(
     cc::mojom::DisplayCompositorRequest request,
     cc::mojom::DisplayCompositorClientPtr client) {
-  gpu_service_->CreateDisplayCompositor(std::move(request), std::move(client));
+  display_compositor_factory_->CreateDisplayCompositor(std::move(request),
+                                                       std::move(client));

[sadrul, 2016/11/29 19:46:41]

Dumb question: why can't WindowServer do this:
  connector->ConnectToInterface("gpu", &display_compositor_);
  display_compositor_->SetClient(std::move(display_compositor_client_binding_));

[Fady Samuel, 2016/11/29 20:08:58]

It can. It's a matter of style I guess. I see no compelling reason to go one way
over the other. If you feel strongly I'll change it. For now, I'm leaving it as
is.

 }
 
 void GpuServiceProxy::OnInitialized(const gpu::GPUInfo& gpu_info) {
   gpu_info_ = gpu_info;
+  // TODO(fsamuel): Once GPU process is split, this would look like:
+  //   connector->ConnectToInterface("gpu", &display_compositor_factory_);
+  gpu_main_.Create(std::move(pending_display_compositor_factory_request_));
 
   delegate_->OnGpuServiceInitialized();
 }
 
 void GpuServiceProxy::OnGpuChannelEstablished(
     const EstablishGpuChannelCallback& callback,
     int32_t client_id,
     mojo::ScopedMessagePipeHandle channel_handle) {
   callback.Run(client_id, std::move(channel_handle), gpu_info_);
 }
@@ skipping 28 matching lines @@
       id, size, format));
 }
 
 void GpuServiceProxy::DestroyGpuMemoryBuffer(gfx::GpuMemoryBufferId id,
                                              const gpu::SyncToken& sync_token) {
   //  NOTIMPLEMENTED();
 }
 
 }  // namespace ws
 }  // namespace ui