Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2539863002: Fix partial-screen flashes when first entering low power full screen. (Closed)

Created:
4 years ago by erikchen
Modified:
4 years ago
Reviewers:
ccameron
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix partial-screen flashes when first entering low power full screen. NSWindow resizing is slow, so try to guess the right size when first creating the window. Furthermore, resizing the window will create implicit animations for the Window's views and layers. Disable those implicit animations. BUG=667511 Committed: https://crrev.com/e3f1197b3132ba4ad7192dfb13591a7bc19afd74 Cr-Commit-Position: refs/heads/master@{#435062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.mm View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
erikchen
ccameron: Please review.
4 years ago (2016-11-29 17:50:33 UTC) #2
ccameron
Nice! Thanks for digging in on this! lgtm
4 years ago (2016-11-29 19:34:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539863002/1
4 years ago (2016-11-29 19:38:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 19:55:44 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 20:01:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3f1197b3132ba4ad7192dfb13591a7bc19afd74
Cr-Commit-Position: refs/heads/master@{#435062}

Powered by Google App Engine
This is Rietveld 408576698