Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issue 2539853002: Update Google pins. (Closed)

Created:
4 years ago by agl
Modified:
4 years ago
Reviewers:
palmer, lgarron
CC:
cbentzel+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Google pins. This change adds the GlobalSign R2 root to the set of acceptable SPKIs for Google properties. BUG=669560 Committed: https://crrev.com/863fe2c9b4a76f0f0d09a17ce59beba2f001d015 Cr-Commit-Position: refs/heads/master@{#436337}

Patch Set 1 #

Patch Set 2 : Update Google pins. #

Patch Set 3 : Fix unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M net/http/http_security_headers_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/transport_security_state_static.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
agl
4 years ago (2016-11-29 17:33:52 UTC) #3
agl
4 years ago (2016-11-30 17:20:45 UTC) #5
palmer
lgtm
4 years ago (2016-11-30 20:29:11 UTC) #6
lgarron
The change is fine, but not LGTM until I figured out how I messed up ...
4 years ago (2016-11-30 20:30:24 UTC) #7
lgarron
On 2016/11/30 at 20:30:24, lgarron wrote: > The change is fine, but not LGTM until ...
4 years ago (2016-12-01 01:21:41 UTC) #8
lgarron
On 2016/12/01 at 01:21:41, lgarron wrote: > On 2016/11/30 at 20:30:24, lgarron wrote: > > ...
4 years ago (2016-12-03 01:59:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539853002/1
4 years ago (2016-12-03 02:01:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/282241)
4 years ago (2016-12-03 02:21:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539853002/40001
4 years ago (2016-12-05 16:44:44 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-05 17:44:09 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-05 17:45:49 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/863fe2c9b4a76f0f0d09a17ce59beba2f001d015
Cr-Commit-Position: refs/heads/master@{#436337}

Powered by Google App Engine
This is Rietveld 408576698