Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: chrome/browser/ui/app_list/app_list_view_delegate.cc

Issue 253983002: Use centered app list position whenever virtual keyboard is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Only change shape when keyboard enabled (not when it *might* be enabled). Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/app_list/app_list_view_delegate.h" 5 #include "chrome/browser/ui/app_list/app_list_view_delegate.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 16 matching lines...) Expand all
27 #include "chrome/browser/ui/host_desktop.h" 27 #include "chrome/browser/ui/host_desktop.h"
28 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h" 28 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
29 #include "chrome/browser/web_applications/web_app.h" 29 #include "chrome/browser/web_applications/web_app.h"
30 #include "chrome/common/extensions/extension_constants.h" 30 #include "chrome/common/extensions/extension_constants.h"
31 #include "chrome/common/url_constants.h" 31 #include "chrome/common/url_constants.h"
32 #include "components/signin/core/browser/signin_manager.h" 32 #include "components/signin/core/browser/signin_manager.h"
33 #include "content/public/browser/browser_thread.h" 33 #include "content/public/browser/browser_thread.h"
34 #include "content/public/browser/page_navigator.h" 34 #include "content/public/browser/page_navigator.h"
35 #include "content/public/browser/user_metrics.h" 35 #include "content/public/browser/user_metrics.h"
36 #include "grit/theme_resources.h" 36 #include "grit/theme_resources.h"
37 #include "ui/app_list/app_list_switches.h"
37 #include "ui/app_list/app_list_view_delegate_observer.h" 38 #include "ui/app_list/app_list_view_delegate_observer.h"
38 #include "ui/app_list/search_box_model.h" 39 #include "ui/app_list/search_box_model.h"
39 #include "ui/app_list/speech_ui_model.h" 40 #include "ui/app_list/speech_ui_model.h"
40 #include "ui/base/resource/resource_bundle.h" 41 #include "ui/base/resource/resource_bundle.h"
41 #include "ui/gfx/geometry/rect.h" 42 #include "ui/gfx/geometry/rect.h"
42 43
43 #if defined(USE_AURA) 44 #if defined(USE_AURA)
44 #include "ui/keyboard/keyboard_controller.h" 45 #include "ui/keyboard/keyboard_controller.h"
46 #include "ui/keyboard/keyboard_util.h"
45 #endif 47 #endif
46 48
47 #if defined(USE_ASH) 49 #if defined(USE_ASH)
48 #include "chrome/browser/ui/ash/app_list/app_sync_ui_state_watcher.h" 50 #include "chrome/browser/ui/ash/app_list/app_sync_ui_state_watcher.h"
49 #endif 51 #endif
50 52
51 #if defined(OS_WIN) 53 #if defined(OS_WIN)
52 #include "chrome/browser/web_applications/web_app_win.h" 54 #include "chrome/browser/web_applications/web_app_win.h"
53 #endif 55 #endif
54 56
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 return NULL; 412 return NULL;
411 413
412 return service->GetSpeechRecognitionContents(); 414 return service->GetSpeechRecognitionContents();
413 } 415 }
414 416
415 const app_list::AppListViewDelegate::Users& 417 const app_list::AppListViewDelegate::Users&
416 AppListViewDelegate::GetUsers() const { 418 AppListViewDelegate::GetUsers() const {
417 return users_; 419 return users_;
418 } 420 }
419 421
422 bool AppListViewDelegate::UseExperimentalAppListPosition() const {
423 if (app_list::switches::IsExperimentalAppListPositionEnabled())
424 return true;
425
426 // keyboard depends upon Aura.
427 #if defined(USE_AURA)
428 // If the virtual keyboard is enabled, use the new app list position. The old
429 // position is too tall, and doesn't fit in the left-over screen space.
430 if (keyboard::IsKeyboardEnabled())
431 return true;
432 #endif
433
434 return false;
435 }
436
420 gfx::Rect AppListViewDelegate::GetVirtualKeyboardBounds() const { 437 gfx::Rect AppListViewDelegate::GetVirtualKeyboardBounds() const {
421 // KeyboardController depends upon Aura. 438 // KeyboardController depends upon Aura.
422 #if defined(USE_AURA) 439 #if defined(USE_AURA)
423 keyboard::KeyboardController* keyboard_controller = 440 keyboard::KeyboardController* keyboard_controller =
424 keyboard::KeyboardController::GetInstance(); 441 keyboard::KeyboardController::GetInstance();
425 if (!keyboard_controller || !keyboard_controller->keyboard_visible()) 442 if (!keyboard_controller || !keyboard_controller->keyboard_visible())
426 return gfx::Rect(); 443 return gfx::Rect();
427 return keyboard_controller->current_keyboard_bounds(); 444 return keyboard_controller->current_keyboard_bounds();
428 #else 445 #else
429 return gfx::Rect(); 446 return gfx::Rect();
430 #endif 447 #endif
431 } 448 }
432 449
433 void AppListViewDelegate::AddObserver( 450 void AppListViewDelegate::AddObserver(
434 app_list::AppListViewDelegateObserver* observer) { 451 app_list::AppListViewDelegateObserver* observer) {
435 observers_.AddObserver(observer); 452 observers_.AddObserver(observer);
436 } 453 }
437 454
438 void AppListViewDelegate::RemoveObserver( 455 void AppListViewDelegate::RemoveObserver(
439 app_list::AppListViewDelegateObserver* observer) { 456 app_list::AppListViewDelegateObserver* observer) {
440 observers_.RemoveObserver(observer); 457 observers_.RemoveObserver(observer);
441 } 458 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698