Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2539813002: Avoid rogue line float re-layout. (Closed)

Created:
4 years ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid rogue line float re-layout. We cannot just lay out an object without setting its position first. That would confuse the fragmenation machinery. Fortunately, it's not even necessary to lay out here. Changed the comment, as an attempt to explain why. BUG=663942 Committed: https://crrev.com/88acad37d1ea59638054bc8b23216a67c392ccc3 Cr-Commit-Position: refs/heads/master@{#435442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fragmentation/change-fragmentainer-height-line-float.html View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
mstensho (USE GERRIT)
4 years ago (2016-11-29 14:25:49 UTC) #4
mstensho (USE GERRIT)
ping?
4 years ago (2016-11-30 18:35:57 UTC) #7
szager1
lgtm
4 years ago (2016-11-30 20:22:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539813002/1
4 years ago (2016-11-30 20:30:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 22:16:55 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-30 22:21:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88acad37d1ea59638054bc8b23216a67c392ccc3
Cr-Commit-Position: refs/heads/master@{#435442}

Powered by Google App Engine
This is Rietveld 408576698