Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 25398003: Revert r1745: "Add an option to prune targets" (Closed)

Created:
7 years, 2 months ago by Shezan Baig (Bloomberg)
Modified:
7 years, 2 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Revert r1745: "Add an option to prune targets" The test does not work on xcode. BUG= R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -183 lines) Patch
M pylib/gyp/__init__.py View 3 chunks +2 lines, -6 lines 0 comments Download
M pylib/gyp/common.py View 1 chunk +0 lines, -8 lines 0 comments Download
M pylib/gyp/input.py View 3 chunks +1 line, -27 lines 0 comments Download
D test/prune_targets/gyptest-prune-targets.py View 1 chunk +0 lines, -55 lines 0 comments Download
D test/prune_targets/lib1.cc View 1 chunk +0 lines, -6 lines 0 comments Download
D test/prune_targets/lib2.cc View 1 chunk +0 lines, -6 lines 0 comments Download
D test/prune_targets/lib3.cc View 1 chunk +0 lines, -6 lines 0 comments Download
D test/prune_targets/lib_indirect.cc View 1 chunk +0 lines, -6 lines 0 comments Download
D test/prune_targets/program.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D test/prune_targets/test1.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D test/prune_targets/test2.gyp View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Shezan Baig (Bloomberg)
Reverting r1745
7 years, 2 months ago (2013-10-01 23:16:50 UTC) #1
Nico
lgtm Thank you!
7 years, 2 months ago (2013-10-01 23:18:34 UTC) #2
Shezan Baig (Bloomberg)
7 years, 2 months ago (2013-10-01 23:20:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1746 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698