Issue 2539783002: Revert "Store library paths relative to a given application root folder."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2539783002: Revert "Store library paths relative to a given application root folder." (Closed)

Created:
4 years ago by asgerf

Modified:
4 years ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Store library paths relative to a given application root folder." This reverts commit 60adb852ad706ecf9424c77d47fa05583d543def. BUG= Committed: https://github.com/dart-lang/sdk/commit/bb540416f27c39d75ee7f243899939fc37a2cd03

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -88 lines)			Patch
M	pkg/kernel/bin/dartk.dart	View	5 chunks	+2 lines, -14 lines	0 comments	Download
M	pkg/kernel/lib/analyzer/loader.dart	View	9 chunks	+12 lines, -17 lines	0 comments	Download
D	pkg/kernel/lib/application_root.dart	View	1 chunk	+0 lines, -50 lines	0 comments	Download
M	pkg/kernel/lib/ast.dart	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	pkg/kernel/lib/repository.dart	View	2 chunks	+50 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

asgerf

TBR dartk stopped working when the given file was outside the application root

4 years ago (2016-11-29 13:54:33 UTC) #2

asgerf

Committed patchset #1 (id:1) manually as bb540416f27c39d75ee7f243899939fc37a2cd03 (presubmit successful).

4 years ago (2016-11-29 13:56:03 UTC) #4

Message was sent while issue was closed.

lgtm