Issue 2539773003: Merge M56: "Remove unnecessary lock on setClient()."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2539773003: Merge M56: "Remove unnecessary lock on setClient()." (Closed)

Created:
4 years ago by DaleCurtis

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Merge M56: "Remove unnecessary lock on setClient()." The lock is unnecessary because the operation is a no-op when client is unchanged (the vast majority of cases). BUG=615589, 647498 TEST=none Review-Url: https://codereview.chromium.org/2527813002 Cr-Commit-Position: refs/heads/master@{#434380} (cherry picked from commit 8be2e3fd36fb909ba695c0bd84ef9f97d3855ac3) Committed: https://chromium.googlesource.com/chromium/src/+/b9b58bdcc7d2914fe016f839751b11149e9f500e

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -9 lines)			Patch
	M	media/blink/webaudiosourceprovider_impl.cc	View		2 chunks	+15 lines, -9 lines	0 comments	Download

Total messages: 2 (1 generated)

DaleCurtis

4 years ago (2016-11-29 21:00:02 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b9b58bdcc7d2914fe016f839751b11149e9f500e.